Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(measure_theory/integral/set_to_l1): various properties of the set_to_fun construction #10713

Closed
wants to merge 17 commits into from

Conversation

RemyDegenne
Copy link
Collaborator


Open in Gitpod

@RemyDegenne RemyDegenne added the awaiting-review The author would like community review of the PR label Dec 11, 2021
@RemyDegenne RemyDegenne added awaiting-author A reviewer has asked the author a question or requested changes awaiting-review The author would like community review of the PR and removed awaiting-review The author would like community review of the PR awaiting-author A reviewer has asked the author a question or requested changes labels Dec 11, 2021
@RemyDegenne RemyDegenne changed the title feat(measure_theory/integral/set_to_L1): various properties of the set_to_fun construction feat(measure_theory/integral/set_to_l1): various properties of the set_to_fun construction Dec 11, 2021
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good to me. I am only wondering whether this can be used to remove the proofs of some statements about the Bochner integral, replacing them with a call to the more general statement. But this should definitely be done in another PR, this one is already big enough.
bors d+

src/measure_theory/function/l1_space.lean Outdated Show resolved Hide resolved
src/measure_theory/function/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/measure/measure_space.lean Outdated Show resolved Hide resolved
src/measure_theory/integral/set_to_l1.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Dec 13, 2021

✌️ RemyDegenne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 13, 2021
@RemyDegenne
Copy link
Collaborator Author

Thanks for the review!

This looks very good to me. I am only wondering whether this can be used to remove the proofs of some statements about the Bochner integral, replacing them with a call to the more general statement. But this should definitely be done in another PR, this one is already big enough.

See PR #10717 :)

@RemyDegenne
Copy link
Collaborator Author

The "Run tests" CI keeps failing and I don't understand what happens. At the export as low-level text file step, I get the error

Run lean --recursive --export=mathlib.txt src/
<unknown>:1:1: error: unknown declaration '_private.3627408217.add'
Error: Process completed with exit code 1.

@RemyDegenne
Copy link
Collaborator Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Dec 14, 2021
bors bot pushed a commit that referenced this pull request Dec 14, 2021
…t_to_fun construction (#10713)




Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
@bors
Copy link

bors bot commented Dec 14, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/integral/set_to_l1): various properties of the set_to_fun construction [Merged by Bors] - feat(measure_theory/integral/set_to_l1): various properties of the set_to_fun construction Dec 14, 2021
@bors bors bot closed this Dec 14, 2021
@bors bors bot deleted the stf_props_2 branch December 14, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants