Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(linear_algebra/orientation): composing with linear equivs and determinant #10737
[Merged by Bors] - feat(linear_algebra/orientation): composing with linear equivs and determinant #10737
Changes from 8 commits
26d5343
7c54504
7a54af4
2720c9f
137932d
092ce81
3ee3b0d
afb759f
c8bb6b3
2d01e46
ccc8ae5
c04fb5e
999c853
71302b9
9063051
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsm28, do you think this lemma is still useful, now that it's just four rewrites?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure what version or versions will end up being most useful when I start working with concrete manipulations of bases to get them into the desired orientation (but also, different versions may end up being useful for different purposes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep them then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The LHS here is
defeqequal to(ray_of_ne_zero R f hf).map g.symm
viaorientation.map_apply
andlinear_equiv.symm_symm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At which point both sides only refer to
f
viaray_of_ne_zero R f hf
, so you can generalize tof : orientation R M ι