[Merged by Bors] - chore(order/hom): rearrange definitions of order_{hom,iso,embedding}
#10752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vierkantor
added
awaiting-review
Closed
1 task
github-actions
bot
added
merge-conflict
* rename `order/order_hom.lean` to `order/hom/basic.lean` * move `order_hom.complete_lattice` to a new file `order/hom/lattice.lean` * reduce imports
Vierkantor
force-pushed
the
move-order_iso
branch
from
8a48c34
to
15ef754
Compare
Vierkantor
removed
blocked-by-other-PR
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
jcommelin
approved these changes
Dec 13, 2021
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
jcommelin
added
the
awaiting-CI
github-actions
bot
added
delegated
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 13, 2021
#10752) We symmetrize the locations of `rel_{hom,iso,embedding}` and `order_{hom,iso,embedding}` by putting the `rel_` definitions in `order/rel_iso.lean` and the `order_` definitions in `order/hom/basic.lean`. (`order_hom.lean` needed to be split up to fix an import loop.) Requested by @YaelDillies. ## Moved definitions * `order_hom`, `order_iso`, `order_embedding` are now in `order/hom/basic.lean` * `order_hom.has_sup` ... `order_hom.complete_lattice` are now in `order/hom/lattice.lean` ## Other changes Some import cleanup.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
order_{hom,iso,embedding}order_{hom,iso,embedding}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We symmetrize the locations of
rel_{hom,iso,embedding}andorder_{hom,iso,embedding}by putting therel_definitions inorder/rel_iso.leanand theorder_definitions inorder/hom/basic.lean. (order_hom.leanneeded to be split up to fix an import loop.) Requested by @YaelDillies.Moved definitions
order_hom,order_iso,order_embeddingare now inorder/hom/basic.leanorder_hom.has_sup...order_hom.complete_latticeare now inorder/hom/lattice.leanOther changes
Some import cleanup.
preorder_homtoorder_hom#10750