Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - split(logic/nonempty): Split off logic.basic #10762

Closed
wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

This moves the lemmas about nonempty to a new file logic.basic

I'm crediting Johannes for 7948318


Open in Gitpod

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 14, 2021
@b-mehta
Copy link
Collaborator

b-mehta commented Dec 14, 2021

The build error is because that file doesn't know what nonempty.elim_to_inhabited is any more - I think you can resolve it by just adding an import

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 14, 2021
@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Dec 14, 2021
@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 15, 2021
bors bot pushed a commit that referenced this pull request Dec 15, 2021
This moves the lemmas about `nonempty` to a new file `logic.basic`

I'm crediting Johannes for 7948318
@bors
Copy link

bors bot commented Dec 15, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title split(logic/nonempty): Split off logic.basic [Merged by Bors] - split(logic/nonempty): Split off logic.basic Dec 15, 2021
@bors bors bot closed this Dec 15, 2021
@bors bors bot deleted the split_nonempty branch December 15, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants