Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/mv_polynomial/equiv): API for mv_polynomial.fin_succ_equiv #10812

Closed
wants to merge 45 commits into from

Conversation

isadofschi
Copy link
Collaborator

@isadofschi isadofschi commented Dec 15, 2021

This PR provides API for mv_polynomial.fin_succ_equiv: coefficients, degree, coefficientes of coefficients, degree_of of coefficients, etc.

To state and prove these lemmas I had to define cons and tail for maps fin (n+1) →₀ M and prove the usual properties for these. I'm not sure if this is necessary or the correct approach to do this.


Open in Gitpod

@isadofschi isadofschi added the awaiting-review The author would like community review of the PR label Dec 15, 2021
@isadofschi isadofschi added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 17, 2021
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some style comments

src/data/finset/lattice.lean Outdated Show resolved Hide resolved
src/data/finset/lattice.lean Outdated Show resolved Hide resolved
src/data/finset/lattice.lean Outdated Show resolved Hide resolved
isadofschi and others added 2 commits December 17, 2021 19:03
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@isadofschi isadofschi added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 17, 2021
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Dec 17, 2021
@isadofschi isadofschi added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 30, 2022
@isadofschi isadofschi added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 30, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for forgetting about this PR. I've been too busy with non-lean things lately.

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 21, 2022
bors bot pushed a commit that referenced this pull request Apr 21, 2022
#10812)

This PR provides API for `mv_polynomial.fin_succ_equiv`: coefficients, degree, coefficientes of coefficients, degree_of of coefficients, etc.

To state and prove these lemmas I had to define `cons` and `tail` for maps `fin (n+1) →₀ M` and prove the usual properties for these. I'm not sure if this is necessary or the correct approach to do this.



Co-authored-by: Iván Sadofschi Costa <isadofschi@users.noreply.github.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Apr 21, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 21, 2022
#10812)

This PR provides API for `mv_polynomial.fin_succ_equiv`: coefficients, degree, coefficientes of coefficients, degree_of of coefficients, etc.

To state and prove these lemmas I had to define `cons` and `tail` for maps `fin (n+1) →₀ M` and prove the usual properties for these. I'm not sure if this is necessary or the correct approach to do this.



Co-authored-by: Iván Sadofschi Costa <isadofschi@users.noreply.github.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Apr 21, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 21, 2022
#10812)

This PR provides API for `mv_polynomial.fin_succ_equiv`: coefficients, degree, coefficientes of coefficients, degree_of of coefficients, etc.

To state and prove these lemmas I had to define `cons` and `tail` for maps `fin (n+1) →₀ M` and prove the usual properties for these. I'm not sure if this is necessary or the correct approach to do this.



Co-authored-by: Iván Sadofschi Costa <isadofschi@users.noreply.github.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Apr 21, 2022

Build failed:

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Apr 21, 2022
@bryangingechen
Copy link
Collaborator

Please merge master and fix any build / lint errors that occur. Then feel free to put this back on the queue!
bors d+

@bors
Copy link

bors bot commented Apr 21, 2022

✌️ isadofschi can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Apr 21, 2022
@isadofschi
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 22, 2022
#10812)

This PR provides API for `mv_polynomial.fin_succ_equiv`: coefficients, degree, coefficientes of coefficients, degree_of of coefficients, etc.

To state and prove these lemmas I had to define `cons` and `tail` for maps `fin (n+1) →₀ M` and prove the usual properties for these. I'm not sure if this is necessary or the correct approach to do this.



Co-authored-by: Iván Sadofschi Costa <isadofschi@users.noreply.github.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Apr 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/mv_polynomial/equiv): API for mv_polynomial.fin_succ_equiv [Merged by Bors] - feat(data/mv_polynomial/equiv): API for mv_polynomial.fin_succ_equiv Apr 22, 2022
@bors bors bot closed this Apr 22, 2022
@bors bors bot deleted the api-fin_succ_equiv branch April 22, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants