[Merged by Bors] - chore(algebra/associated): split off dependencies of big_operators
#10848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares for the replacement of `nat.prime` with `_root_.prime` by reducing the amount of dependencies needed to define `_root_.prime`. Note that there wouldn't be an import loop without this change, just that `data/nat/prime.lean` would have a bigger amount of imports. Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/nat.2Eprime
Vierkantor
added
WIP
eric-wieser
reviewed
Dec 16, 2021
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
approved these changes
Dec 16, 2021
github-actions
bot
added
delegated
|
👎 Rejected by label |
github-actions
bot
added
the
ready-to-merge
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 17, 2021
…10848) This prepares for the replacement of `nat.prime` with `_root_.prime` by reducing the amount of dependencies needed to define `_root_.prime`. Note that there wouldn't be an import loop without this change, just that `data/nat/prime.lean` would have a bigger amount of imports. Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/nat.2Eprime Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
big_operatorsbig_operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares for the replacement of
nat.primewith_root_.primeby reducing the amount of dependencies needed to define_root_.prime.Note that there wouldn't be an import loop without this change, just that
data/nat/prime.leanwould have a bigger amount of imports.Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/nat.2Eprime
WIP because I might have to modify the imports of some files depending on
algebra.associated.