Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(combinatorics/simple_graph/matching): is_matching iff all degrees = 1 #10864

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(combinatorics/simple_graph/matching): is_matching iff all degrees = 1 #10864

wants to merge 3 commits into from

Conversation

arthurpaulino
Copy link
Collaborator

Open in Gitpod

kmill
kmill reviewed Dec 18, 2021
View reviewed changes
Copy link
Collaborator

@kmill kmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about what to name things, but here are some options to start things off.

src/combinatorics/simple_graph/subgraph.lean Outdated Show resolved Hide resolved
src/combinatorics/simple_graph/matching.lean Outdated Show resolved Hide resolved
src/combinatorics/simple_graph/subgraph.lean Outdated Show resolved Hide resolved
@arthurpaulino arthurpaulino added the awaiting-review The author would like community review of the PR label Dec 18, 2021
kmill
kmill approved these changes Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@kmill kmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but it would be nice if someone else reviewed the naming convention too.

Vierkantor
Vierkantor approved these changes Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names look sensible to me and this already had some 👍s, so I'm happy to merge this 🎉

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 20, 2021
bors bot pushed a commit that referenced this pull request Dec 20, 2021
@arthurpaulino
feat(combinatorics/simple_graph/matching): is_matching iff all degree…
bcf20b0 
…s = 1 (#10864)
@bors
Copy link

bors bot commented Dec 20, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(combinatorics/simple_graph/matching): is_matching iff all degrees = 1 [Merged by Bors] - feat(combinatorics/simple_graph/matching): is_matching iff all degrees = 1 Dec 20, 2021
@bors bors bot closed this Dec 20, 2021
@bors bors bot deleted the more-on-graph-matchings branch December 20, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmill kmill kmill approved these changes

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arthurpaulino @kmill @Vierkantor