Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/group_power/basic): generalize zpow_neg_one to div_inv_monoid #10894

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(algebra/group_power/basic): generalize zpow_neg_one to div_inv_monoid #10894

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 19, 2021

Drop zpow_neg_one₀

Open in Gitpod

@urkud urkud added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Dec 19, 2021
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Dec 19, 2021
eric-wieser
eric-wieser approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does zpow_neg₀ generalize too?

bors d+

@bors
Copy link

bors bot commented Dec 19, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Dec 19, 2021
@urkud
Copy link
Member Author

urkud commented Dec 19, 2021

Does zpow_neg₀ generalize too?

No, div_inv_monoid doesn't require 1⁻¹ = 1.

@urkud
Copy link
Member Author

urkud commented Dec 19, 2021

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Dec 19, 2021
bors bot pushed a commit that referenced this pull request Dec 19, 2021
@urkud
feat(algebra/group_power/basic): generalize zpow_neg_one to `div_in…
9e5cbc1 
…v_monoid` (#10894)

Drop `zpow_neg_one₀`
@urkud urkud mentioned this pull request Dec 19, 2021
Closed
3 tasks
@bors
Copy link

bors bot commented Dec 19, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/group_power/basic): generalize zpow_neg_one to div_inv_monoid [Merged by Bors] - feat(algebra/group_power/basic): generalize zpow_neg_one to div_inv_monoid Dec 19, 2021
@bors bors bot closed this Dec 19, 2021
@bors bors bot deleted the YK-zpow-neg-one branch December 19, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @eric-wieser