Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/sigma/interval): A disjoint sum of locally finite orders is locally finite #10929

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(data/sigma/interval): A disjoint sum of locally finite orders is locally finite #10929

wants to merge 7 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Dec 20, 2021 •
edited

This provides locally_finite_order (Σ i, α i) in a new file data.sigma.interval. This also makes < a primitive on Σ i, α i.

I'm working on the lexicographical but ugh it's horrendous.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Dec 20, 2021
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 20, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 21, 2021
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 4, 2022
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

This PR/issue depends on:

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 4, 2022
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 5, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 5, 2022
jcommelin
jcommelin approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 12, 2022
bors bot pushed a commit that referenced this pull request Jan 12, 2022
@YaelDillies
feat(data/sigma/interval): A disjoint sum of locally finite orders is…
aaa2a45 
… locally finite (#10929)

This provides `locally_finite_order (Σ i, α i)` in a new file `data.sigma.interval`. This also makes `<` a primitive on `Σ i, α i`.
@bors
Copy link

bors bot commented Jan 12, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jan 12, 2022
@YaelDillies
feat(data/sigma/interval): A disjoint sum of locally finite orders is…
aece00a 
… locally finite (#10929)

This provides `locally_finite_order (Σ i, α i)` in a new file `data.sigma.interval`. This also makes `<` a primitive on `Σ i, α i`.
@bors
Copy link

bors bot commented Jan 12, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/sigma/interval): A disjoint sum of locally finite orders is locally finite [Merged by Bors] - feat(data/sigma/interval): A disjoint sum of locally finite orders is locally finite Jan 12, 2022
@bors bors bot closed this Jan 12, 2022
@bors bors bot deleted the localfinorder_sigma branch January 12, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@b-mehta b-mehta b-mehta left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YaelDillies @eric-wieser @jcommelin @b-mehta @leanprover-community-bot-assistant