Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - [Merged by Bors] - feat(field_theory/adjoin): intermediate_field.to_subalgebra distributes over supremum #10937

Closed
wants to merge 6 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Dec 20, 2021

This PR proves (E1 ⊔ E2).to_subalgebra = E1.to_subalgebra ⊔ E2.to_subalgebra, under the assumption that E1 and E2 are finite-dimensional over F.


Open in Gitpod

@tb65536 tb65536 added the awaiting-review The author would like community review of the PR label Dec 20, 2021
src/field_theory/adjoin.lean Outdated Show resolved Hide resolved
src/field_theory/adjoin.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 23, 2021
bors bot pushed a commit that referenced this pull request Dec 23, 2021
…utes over supremum (#10937)

This PR proves `(E1 ⊔ E2).to_subalgebra = E1.to_subalgebra ⊔ E2.to_subalgebra`, under the assumption that `E1` and `E2` are finite-dimensional over `F`.



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
@bors
Copy link

bors bot commented Dec 23, 2021

Build failed (retrying...):

@urkud
Copy link
Member

urkud commented Dec 23, 2021

bors r-

@bors
Copy link

bors bot commented Dec 23, 2021

Canceled.

@urkud
Copy link
Member

urkud commented Dec 23, 2021

bors r+

begin
let S1 := E1.to_subalgebra,
let S2 := E2.to_subalgebra,
refine le_antisymm (show _ ≤ (S1 ⊔ S2).to_intermediate_field _, from (sup_le (show S1 ≤ _,
Copy link
Collaborator

@ericrbg ericrbg Dec 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is getting merged already, but what's the defeq going on in this show? Is there a lemma for it?

bors bot pushed a commit that referenced this pull request Dec 23, 2021
…utes over supremum (#10937)

This PR proves `(E1 ⊔ E2).to_subalgebra = E1.to_subalgebra ⊔ E2.to_subalgebra`, under the assumption that `E1` and `E2` are finite-dimensional over `F`.



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
@bors
Copy link

bors bot commented Dec 23, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/adjoin): intermediate_field.to_subalgebra distributes over supremum [Merged by Bors] - feat(field_theory/adjoin): intermediate_field.to_subalgebra distributes over supremum Dec 23, 2021
@bors bors bot closed this Dec 23, 2021
@bors
Copy link

bors bot commented Dec 23, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title [Merged by Bors] - feat(field_theory/adjoin): intermediate_field.to_subalgebra distributes over supremum [Merged by Bors] - [Merged by Bors] - feat(field_theory/adjoin): intermediate_field.to_subalgebra distributes over supremum Dec 23, 2021
@tb65536 tb65536 deleted the intermediate_field.sup_to_subalgebra branch September 29, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants