Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/associated): add lemmas to split #9345 #10941

Closed
wants to merge 21 commits into from
Closed

[Merged by Bors] - feat(algebra/associated): add lemmas to split #9345 #10941

wants to merge 21 commits into from

Conversation

Paul-Lez
Copy link
Collaborator

@Paul-Lez Paul-Lez commented Dec 20, 2021 •
edited by alexjbest

This PR contains lemmas from PR #9345, which was starting to get quite lengthy.

Co-authored-by: Anne Baanen.

Open in Gitpod

@Paul-Lez Paul-Lez added the awaiting-review The author would like community review of the PR label Dec 21, 2021
@Paul-Lez Paul-Lez mentioned this pull request Dec 21, 2021
Closed
1 task
jcommelin
jcommelin reviewed Dec 23, 2021
View reviewed changes
src/algebra/associated.lean Outdated Show resolved Hide resolved
src/algebra/associated.lean Outdated Show resolved Hide resolved
src/algebra/associated.lean Outdated Show resolved Hide resolved
src/algebra/associated.lean Outdated Show resolved Hide resolved
src/algebra/associated.lean Outdated Show resolved Hide resolved
src/algebra/associated.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 23, 2021
Paul-Lez and others added 7 commits December 25, 2021 16:20
@Paul-Lez @jcommelin
Update src/algebra/associated.lean
3a1bf25 
Co-authored-by: Johan Commelin <johan@commelin.net>
@Paul-Lez @jcommelin
Update src/algebra/associated.lean
154aa4c 
Co-authored-by: Johan Commelin <johan@commelin.net>
@Paul-Lez @jcommelin
Update src/algebra/associated.lean
973bfb6 
Co-authored-by: Johan Commelin <johan@commelin.net>
@Paul-Lez @jcommelin
Update src/algebra/associated.lean
4dd38a0 
Co-authored-by: Johan Commelin <johan@commelin.net>
@Paul-Lez @jcommelin
Update src/algebra/associated.lean
c74b830 
Co-authored-by: Johan Commelin <johan@commelin.net>
@Paul-Lez
corrections
8a7e185
@Paul-Lez
moved lemma
9d159b3
@Paul-Lez Paul-Lez added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 25, 2021
@Paul-Lez Paul-Lez mentioned this pull request Dec 25, 2021
Closed
2 tasks
adomani
adomani reviewed Dec 28, 2021
View reviewed changes
Copy link
Collaborator

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little bit of golfing!

src/algebra/associated.lean Outdated Show resolved Hide resolved
src/algebra/associated.lean Outdated Show resolved Hide resolved
src/algebra/associated.lean Outdated Show resolved Hide resolved
src/algebra/associated.lean Outdated Show resolved Hide resolved
src/algebra/associated.lean Outdated Show resolved Hide resolved
src/algebra/associated.lean Outdated Show resolved Hide resolved
Paul-Lez and others added 6 commits December 28, 2021 13:48
@Paul-Lez @adomani
Update src/algebra/associated.lean
ed04630 
Co-authored-by: damiano <adomani@gmail.com>
@Paul-Lez @adomani
Update src/algebra/associated.lean
baf38e2 
Co-authored-by: damiano <adomani@gmail.com>
@Paul-Lez @adomani
Update src/algebra/associated.lean
b06bd62 
Co-authored-by: damiano <adomani@gmail.com>
@Paul-Lez @adomani
Update src/algebra/associated.lean
fc3dc8a 
Co-authored-by: damiano <adomani@gmail.com>
@Paul-Lez @adomani
Update src/algebra/associated.lean
069cf72 
Co-authored-by: damiano <adomani@gmail.com>
@Paul-Lez @adomani
Update src/algebra/associated.lean
fa7069f 
Co-authored-by: damiano <adomani@gmail.com>
@Paul-Lez
Copy link
Collaborator Author

@adomani thanks for the review ;-)

urkud
urkud reviewed Jan 3, 2022
View reviewed changes
src/algebra/associated.lean Outdated Show resolved Hide resolved
urkud
urkud reviewed Jan 3, 2022
View reviewed changes
src/algebra/divisibility.lean Outdated Show resolved Hide resolved
@Paul-Lez @urkud
Update src/algebra/divisibility.lean
8486959 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@Paul-Lez Paul-Lez added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 4, 2022
@Paul-Lez Paul-Lez added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 6, 2022
Vierkantor
Vierkantor approved these changes Jan 6, 2022
View reviewed changes
src/algebra/associated.lean Outdated Show resolved Hide resolved
src/algebra/associated.lean Outdated Show resolved Hide resolved
Paul-Lez and others added 2 commits January 6, 2022 20:16
@Paul-Lez @Vierkantor
Update src/algebra/associated.lean
744424b 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@Paul-Lez @Vierkantor
Update src/algebra/associated.lean
c24ed09 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@Paul-Lez Paul-Lez added awaiting-CI The author would like to see what CI has to say before doing more work. and removed awaiting-review The author would like community review of the PR labels Jan 6, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jan 6, 2022
@Paul-Lez Paul-Lez added the awaiting-review The author would like community review of the PR label Jan 7, 2022
@robertylewis
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 10, 2022
bors bot pushed a commit that referenced this pull request Jan 10, 2022
@Paul-Lez
feat(algebra/associated): add lemmas to split #9345 (#10941)
8e92af1 
This PR contains lemmas from PR [#9345](#9345), which was starting to get quite lengthy. 

Co-authored-by: Anne Baanen.
@bors
Copy link

bors bot commented Jan 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/associated): add lemmas to split #9345 [Merged by Bors] - feat(algebra/associated): add lemmas to split #9345 Jan 11, 2022
@bors bors bot closed this Jan 11, 2022
@bors bors bot deleted the monoid_proofs branch January 11, 2022 02:45
@eric-wieser eric-wieser restored the monoid_proofs branch January 11, 2022 08:49
@eric-wieser eric-wieser deleted the monoid_proofs branch January 11, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

@jcommelin jcommelin jcommelin left review comments

@adomani adomani adomani left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Paul-Lez @robertylewis @urkud @Vierkantor @jcommelin @adomani