Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - split(data/finset/sigma): Split off data.finset.basic #10957

Closed
wants to merge 3 commits into from

Conversation

YaelDillies
Copy link
Collaborator

This moves finset.sigma to a new file data.finset.sigma.

I'm crediting Mario for 16d40d7


Soon, there will be a new definition finset.sigma_lift coming in.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Dec 21, 2021
@eric-wieser
Copy link
Member

I think it might make sense to move sup_sigma (which is currently failing` to the new file too. Does that make sense to you?

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 22, 2021
bors bot pushed a commit that referenced this pull request Dec 22, 2021
This moves `finset.sigma` to a new file `data.finset.sigma`.

I'm crediting Mario for 16d40d7
@bors
Copy link

bors bot commented Dec 23, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title split(data/finset/sigma): Split off data.finset.basic [Merged by Bors] - split(data/finset/sigma): Split off data.finset.basic Dec 23, 2021
@bors bors bot closed this Dec 23, 2021
@bors bors bot deleted the split_finset_sigma branch December 23, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants