Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/is_locally_homeomorph): New file #10960

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat(topology/is_locally_homeomorph): New file #10960

wants to merge 9 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Dec 21, 2021

This PR defines local homeomorphisms.

Open in Gitpod

@tb65536 tb65536 added the awaiting-review The author would like community review of the PR label Dec 21, 2021
@bryangingechen bryangingechen changed the title feat(topology.is_locally_homeomorph): New file feat(topology/is_locally_homeomorph): New file Dec 22, 2021
jcommelin
jcommelin reviewed Dec 23, 2021
View reviewed changes
src/topology/is_locally_homeomorph.lean Outdated Show resolved Hide resolved
src/topology/is_locally_homeomorph.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 23, 2021
@tb65536 tb65536 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 23, 2021
urkud
urkud reviewed Dec 23, 2021
View reviewed changes
Copy link
Member

@urkud urkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

I made some comments, mostly about missing lemmas and imperfect docstrings. Could you please fix these issues and add homeomorph.is_locally_homeomorph?

src/topology/is_locally_homeomorph.lean Outdated Show resolved Hide resolved
src/topology/is_locally_homeomorph.lean Outdated Show resolved Hide resolved
src/topology/is_locally_homeomorph.lean Outdated Show resolved Hide resolved
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 23, 2021
@tb65536 tb65536 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 23, 2021
urkud
urkud reviewed Dec 23, 2021
View reviewed changes
Copy link
Member

@urkud urkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more trivial remarks, otherwise look good to me. Thanks!

bors d+

src/topology/is_locally_homeomorph.lean Outdated Show resolved Hide resolved
src/topology/is_locally_homeomorph.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Dec 23, 2021

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 24, 2021
bors bot pushed a commit that referenced this pull request Dec 24, 2021
@tb65536
feat(topology/is_locally_homeomorph): New file (#10960)
028c161 
This PR defines local homeomorphisms.
@bors
Copy link

bors bot commented Dec 24, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/is_locally_homeomorph): New file [Merged by Bors] - feat(topology/is_locally_homeomorph): New file Dec 24, 2021
@bors bors bot closed this Dec 24, 2021
@bors bors bot deleted the local_homeomorphism branch December 24, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tb65536 @jcommelin @urkud