[Merged by Bors] - feat(field_theory/adjoin): add dim_bot, finrank_bot #10964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebastian-Monnet
added
the
awaiting-review
eric-wieser
reviewed
Dec 22, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Thank you for this PR :-) However both of these are themselves true Is there some benefit I'm missing? |
ocfnash
added
awaiting-author
|
Yes, these are worth having because they teach simp how to simplify something like (Note also that the simp linter does not reject them) |
|
bors merge Thanks! |
github-actions
bot
added
ready-to-merge
eric-wieser
changed the title
eric-wieser
changed the title
bors bot
pushed a commit
that referenced
this pull request
Dec 23, 2021
Added two simp lemmas, showing that the dimension and finrank respectively of bottom intermediate fields are 1. Co-authored-by: Sebastian-Monnet <54352341+Sebastian-Monnet@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Aha, thanks of course! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two simp lemmas, showing that the dimension and finrank respectively of bottom intermediate fields are 1.