Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(order/*): Change order_hom notation #10988

Closed
wants to merge 1 commit into from

Conversation

YaelDillies
Copy link
Collaborator

This changes the notation for order_hom from α →ₘ β to α →o β to match order_embedding and order_iso, which are respectively α ↪o β and α ≃o β. This also solves the conflict with measurable functions.


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Dec 23, 2021
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let another maintainer sign off

@digama0
Copy link
Member

digama0 commented Dec 23, 2021

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 23, 2021
bors bot pushed a commit that referenced this pull request Dec 23, 2021
This changes the notation for `order_hom` from `α →ₘ β` to `α →o β` to match `order_embedding` and `order_iso`, which are respectively `α ↪o β` and `α ≃o β`. This also solves the conflict with measurable functions.
@bors
Copy link

bors bot commented Dec 23, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(order/*): Change order_hom notation [Merged by Bors] - chore(order/*): Change order_hom notation Dec 23, 2021
@bors bors bot closed this Dec 23, 2021
@bors bors bot deleted the order_hom_notation branch December 23, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants