Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/polynomial): more API for roots #11081

Closed
wants to merge 9 commits into from

Conversation

pechersky
Copy link
Collaborator

@pechersky pechersky commented Dec 27, 2021

leading_coeff_monic_mul
leading_coeff_X_sub_C
root_multiplicity_C
not_is_root_C
roots_smul_nonzero
leading_coeff_div_by_monic_X_sub_C
roots_eq_zero_iff

also generalized various statements about X - C a to X + C a over semirings.


Open in Gitpod

@pechersky pechersky added awaiting-CI The author would like to see what CI has to say before doing more work. awaiting-review The author would like community review of the PR labels Dec 27, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 27, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 27, 2021
Copy link
Collaborator

@ericrbg ericrbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/data/polynomial/degree/definitions.lean Show resolved Hide resolved
src/field_theory/is_alg_closed/basic.lean Outdated Show resolved Hide resolved
src/data/polynomial/ring_division.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Dec 28, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 29, 2021
bors bot pushed a commit that referenced this pull request Dec 29, 2021
`leading_coeff_monic_mul`
`leading_coeff_X_sub_C`
`root_multiplicity_C`
`not_is_root_C`
`roots_smul_nonzero`
`leading_coeff_div_by_monic_X_sub_C`
`roots_eq_zero_iff`

also generalized various statements about `X - C a` to `X + C a` over semirings.



Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
@bors
Copy link

bors bot commented Dec 29, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/polynomial): more API for roots [Merged by Bors] - feat(data/polynomial): more API for roots Dec 29, 2021
@bors bors bot closed this Dec 29, 2021
@bors bors bot deleted the pechersky/roots-API branch December 29, 2021 13:33
erdOne pushed a commit that referenced this pull request Jan 1, 2022
`leading_coeff_monic_mul`
`leading_coeff_X_sub_C`
`root_multiplicity_C`
`not_is_root_C`
`roots_smul_nonzero`
`leading_coeff_div_by_monic_X_sub_C`
`roots_eq_zero_iff`

also generalized various statements about `X - C a` to `X + C a` over semirings.



Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants