Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/fin/interval): add lemmas #11102

Closed
wants to merge 18 commits into from
Closed

[Merged by Bors] - feat(data/fin/interval): add lemmas #11102

wants to merge 18 commits into from

Conversation

riccardobrasca
Copy link
Member

From flt-regular.

Open in Gitpod

@riccardobrasca riccardobrasca added the awaiting-review The author would like community review of the PR label Dec 28, 2021
YaelDillies
YaelDillies reviewed Dec 28, 2021
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the Icc, Ico, Ioc, Ioo variants.

src/data/finset/locally_finite.lean Outdated Show resolved Hide resolved
src/data/finset/locally_finite.lean Outdated Show resolved Hide resolved
src/data/fin/interval.lean Outdated Show resolved Hide resolved
src/data/fin/interval.lean Outdated Show resolved Hide resolved
src/data/fin/interval.lean Outdated Show resolved Hide resolved
src/data/fin/interval.lean Outdated Show resolved Hide resolved
src/data/fin/interval.lean Outdated Show resolved Hide resolved
riccardobrasca and others added 10 commits December 28, 2021 21:16
@riccardobrasca
add lemmas
5862fe9
@riccardobrasca @YaelDillies
Update src/data/finset/locally_finite.lean
5774e99 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@riccardobrasca
better names
caeefac
@riccardobrasca
fix build
33bf443
@riccardobrasca @YaelDillies
Update src/data/fin/interval.lean
5f7c6e2 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@riccardobrasca
fix build
6b6af42
@riccardobrasca
golf
4244e0a
@riccardobrasca @YaelDillies
Update src/data/fin/interval.lean
01d9c63 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@riccardobrasca
better names
ab8ee48
@riccardobrasca
add lemmas
ec252c4
@riccardobrasca
Copy link
Member Author

I think I've taken into account all your comments, thank you!

YaelDillies
YaelDillies approved these changes Dec 28, 2021
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

src/data/fin/interval.lean Outdated Show resolved Hide resolved
src/data/finset/locally_finite.lean Outdated Show resolved Hide resolved
src/data/fin/interval.lean Outdated Show resolved Hide resolved
jcommelin
jcommelin approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 30, 2021
bors bot pushed a commit that referenced this pull request Dec 30, 2021
@riccardobrasca
feat(data/fin/interval): add lemmas (#11102)
11de867 
From flt-regular.
@bors
Copy link

bors bot commented Dec 30, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/fin/interval): add lemmas [Merged by Bors] - feat(data/fin/interval): add lemmas Dec 30, 2021
@bors bors bot closed this Dec 30, 2021
@bors bors bot deleted the RB_interveral_filter branch December 30, 2021 16:51
erdOne pushed a commit that referenced this pull request Jan 1, 2022
@riccardobrasca @erdOne
feat(data/fin/interval): add lemmas (#11102)
ecc9443 
From flt-regular.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@riccardobrasca @jcommelin @YaelDillies