Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/normed_space/dual): add lemmas, golf #11132

Closed
wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 29, 2021

  • add polar_univ, is_closed_polar, polar_gc, polar_Union,
    polar_union, polar_antitone, polar_zero, polar_closure;

  • extract polar_ball_subset_closed_ball_div and
    closed_ball_inv_subset_polar_closed_ball out of the proofs of
    polar_closed_ball and polar_bounded_of_nhds_zero;

  • rename polar_bounded_of_nhds_zero to
    bounded_polar_of_mem_nhds_zero, use metric.bounded;

  • use r⁻¹ instead of 1 / r in polar_closed_ball. This is the
    simp normal form (though we might want to change this in the future).


Open in Gitpod

* add `polar_univ`, `is_closed_polar`, `polar_gc`, `polar_Union`,
  `polar_union`, `polar_antitone`, `polar_zero`, `polar_closure`;

* extract `polar_ball_subset_closed_ball_div` and
  `closed_ball_inv_subset_polar_closed_ball` out of the proofs of
  `polar_closed_ball` and `polar_bounded_of_nhds_zero`;

* rename `polar_bounded_of_nhds_zero` to
  `bounded_polar_of_mem_nhds_zero`, use `metric.bounded`;

* use `r⁻¹` instead of `1 / r` in `polar_closed_ball`. This is the
  simp normal form (though we might want to change this in the future).
@github-actions github-actions bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Dec 29, 2021
@github-actions
Copy link

This PR/issue depends on:

Copy link
Member

@PatrickMassot PatrickMassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

variable (E)

lemma polar_gc :
galois_connection (order_dual.to_dual ∘ polar 𝕜)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this order_dual.to_dual ∘ is worth a docstring comment.

src/analysis/normed_space/dual.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Dec 29, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Dec 29, 2021
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
@urkud
Copy link
Member Author

urkud commented Dec 30, 2021

bors merge

bors bot pushed a commit that referenced this pull request Dec 30, 2021
* add `polar_univ`, `is_closed_polar`, `polar_gc`, `polar_Union`,
  `polar_union`, `polar_antitone`, `polar_zero`, `polar_closure`;

* extract `polar_ball_subset_closed_ball_div` and
  `closed_ball_inv_subset_polar_closed_ball` out of the proofs of
  `polar_closed_ball` and `polar_bounded_of_nhds_zero`;

* rename `polar_bounded_of_nhds_zero` to
  `bounded_polar_of_mem_nhds_zero`, use `metric.bounded`;

* use `r⁻¹` instead of `1 / r` in `polar_closed_ball`. This is the
  simp normal form (though we might want to change this in the future).
@bors
Copy link

bors bot commented Dec 30, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/normed_space/dual): add lemmas, golf [Merged by Bors] - feat(analysis/normed_space/dual): add lemmas, golf Dec 30, 2021
@bors bors bot closed this Dec 30, 2021
@bors bors bot deleted the YK-polar-review branch December 30, 2021 01:02
erdOne pushed a commit that referenced this pull request Jan 1, 2022
* add `polar_univ`, `is_closed_polar`, `polar_gc`, `polar_Union`,
  `polar_union`, `polar_antitone`, `polar_zero`, `polar_closure`;

* extract `polar_ball_subset_closed_ball_div` and
  `closed_ball_inv_subset_polar_closed_ball` out of the proofs of
  `polar_closed_ball` and `polar_bounded_of_nhds_zero`;

* rename `polar_bounded_of_nhds_zero` to
  `bounded_polar_of_mem_nhds_zero`, use `metric.bounded`;

* use `r⁻¹` instead of `1 / r` in `polar_closed_ball`. This is the
  simp normal form (though we might want to change this in the future).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants