Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(number_theory/quadratic_reciprocity): Eliminate finish #11133

Closed
wants to merge 3 commits into from

Conversation

stuart-presnell
Copy link
Collaborator

Removing uses of finish, as discussed in this Zulip thread (https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/mathlib.20sat.20solvers)


Open in Gitpod

@stuart-presnell stuart-presnell added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Dec 29, 2021
Copy link
Member

@PatrickMassot PatrickMassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 29, 2021
bors bot pushed a commit that referenced this pull request Dec 29, 2021
@bors
Copy link

bors bot commented Dec 29, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(number_theory/quadratic_reciprocity): Eliminate finish [Merged by Bors] - chore(number_theory/quadratic_reciprocity): Eliminate finish Dec 29, 2021
@bors bors bot closed this Dec 29, 2021
@bors bors bot deleted the SP_quadratic_finish branch December 29, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants