Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(data/fintype/basic): documenting elaboration bug #11247

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - chore(data/fintype/basic): documenting elaboration bug #11247

wants to merge 12 commits into from

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Jan 4, 2022

Simplifying an expression and documenting an elaboration bug that it was avoiding.

Open in Gitpod

@kmill kmill changed the title chore(data/fintype/basic): documenting lemma and elaboration bug chore(data/fintype/basic): documenting elaboration bug Jan 4, 2022
@kmill kmill requested a review from eric-wieser January 4, 2022 22:20
@kmill kmill added the awaiting-review The author would like community review of the PR label Jan 4, 2022
@eric-wieser
Copy link
Member

This conflicts with #11244

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 5, 2022
@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 12, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 25, 2022
@kmill kmill added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 25, 2022
Vierkantor
Vierkantor approved these changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 9, 2022
bors bot pushed a commit that referenced this pull request Feb 9, 2022
@kmill
chore(data/fintype/basic): documenting elaboration bug (#11247)
fea68aa 
Simplifying an expression and documenting an elaboration bug that it was avoiding.
@bors
Copy link

bors bot commented Feb 9, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/fintype/basic): documenting elaboration bug [Merged by Bors] - chore(data/fintype/basic): documenting elaboration bug Feb 9, 2022
@bors bors bot closed this Feb 9, 2022
@bors bors bot deleted the kmill_set_to_finset_univ branch February 9, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kmill @eric-wieser @Vierkantor @bryangingechen @leanprover-community-bot-assistant