Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(combinatorics/set_family/lym): Lubell-Yamamoto-Meshalkin inequalities #11248

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - feat(combinatorics/set_family/lym): Lubell-Yamamoto-Meshalkin inequalities #11248

wants to merge 15 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Jan 4, 2022 •
edited by github-actions bot

This proves the two local LYM inequalities, the LYM inequality and Sperner's theorem.

Co-authored-by: Bhavik Mehta bhavikmehta8@gmail.com
Co-authored-by: Alena Gusakov @agusakov

Most of it could be generalized to grade orders (#11308) but Bhavik and I are of the opinion that this version is worth having either way. I also made sure that the material generalizes easily to graded orders.

Open in Gitpod

@YaelDillies YaelDillies added the RFC Request for comment label Jan 4, 2022
b-mehta
b-mehta reviewed Jan 4, 2022
View reviewed changes
src/combinatorics/set_family/lym.lean Outdated Show resolved Hide resolved
src/combinatorics/set_family/lym.lean Outdated Show resolved Hide resolved
src/combinatorics/set_family/lym.lean Outdated Show resolved Hide resolved
@b-mehta
Copy link
Collaborator

b-mehta commented Jan 4, 2022

I think your TODO list is sensible, and would be a great thing to add to the TODO of the new file! In my view, this material is useful without the generalisation, eg Sperner's theorem doesn't generalise to graded orders!

@YaelDillies YaelDillies added this to In progress in Graph Theory and Combinatorics via automation Jan 5, 2022
b-mehta
b-mehta approved these changes Jan 7, 2022
View reviewed changes
src/combinatorics/set_family/lym.lean Outdated Show resolved Hide resolved
src/data/finset/slice.lean Outdated Show resolved Hide resolved
src/order/antichain.lean Outdated Show resolved Hide resolved
src/combinatorics/set_family/lym.lean Outdated Show resolved Hide resolved
@YaelDillies YaelDillies mentioned this pull request Jan 8, 2022
Closed
2 tasks
@leanprover-community-bot-assistant leanprover-community-bot-assistant added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jan 11, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Jan 12, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jan 19, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 21, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Feb 11, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Feb 16, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Feb 16, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Feb 16, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed RFC Request for comment labels Feb 16, 2022
kmill
kmill reviewed Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@kmill kmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know LYM, but it looks like everything is reasonably designed.

How do we feel about the names local_lym and lubell_yamamoto_meshalkin? Unless there's a good reason not to, they probably should be mathlib-ified.

src/combinatorics/set_family/lym.lean Outdated Show resolved Hide resolved
src/combinatorics/set_family/lym.lean Outdated Show resolved Hide resolved
@kmill
Copy link
Collaborator

kmill commented Mar 1, 2022

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 1, 2022
bors bot pushed a commit that referenced this pull request Mar 1, 2022
@YaelDillies @b-mehta
feat(combinatorics/set_family/lym): Lubell-Yamamoto-Meshalkin inequal…
29c84f7 
…ities (#11248)

This proves the two local LYM inequalities, the LYM inequality and Sperner's theorem.

Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
Co-authored-by: Alena Gusakov @agusakov
@bors
Copy link

bors bot commented Mar 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(combinatorics/set_family/lym): Lubell-Yamamoto-Meshalkin inequalities [Merged by Bors] - feat(combinatorics/set_family/lym): Lubell-Yamamoto-Meshalkin inequalities Mar 1, 2022
@bors bors bot closed this Mar 1, 2022
Graph Theory and Combinatorics automation moved this from In progress to Done Mar 1, 2022
@bors bors bot deleted the lym branch March 1, 2022 19:11
@b-mehta b-mehta mentioned this pull request Jun 8, 2022
Closed
bors bot pushed a commit that referenced this pull request Jun 8, 2022
@b-mehta
chore(data/finset): remove duplicated lemma (#14607)
e39af18 
The lemma `ssubset_iff_exists_insert_subset` was added in #11248 but is just a duplicate of the `ssubset_iff` lemma a few lines earlier in the file. It's only used once.




Co-authored-by: Bhavik Mehta <bm489@cam.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmill kmill kmill left review comments

@dwarn dwarn dwarn left review comments

@b-mehta b-mehta b-mehta approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
Graph Theory and Combinatorics
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YaelDillies @b-mehta @leanprover-community-bot-assistant @kmill @dwarn