Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(set_theory/ordinal_arithmetic): Rename power to opow #11279

Closed
wants to merge 2 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jan 6, 2022


Open in Gitpod

@vihdzp vihdzp added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Jan 6, 2022
@alexjbest
Copy link
Member

If you still have the branch you were testing this out on it would be good to know if changing the name and making these defs lemmas protected lemma (so they have to be referred to by their full name ordinal.pow) would work. That would be my instinct for how to proceed when we have name clashes in mathlib normally

@robertylewis
Copy link
Member

Ahh. Power names are annoying, because there are various different powers that don't really generalize. In other corners of the library, it seems like the pattern is to use the name {x}pow: rpow on the reals, zpow on groups, ... so maybe ordinal powers should be opow?

@robertylewis robertylewis removed the easy < 20s of review time. See the lifecycle page for guidelines. label Jan 6, 2022
@vihdzp
Copy link
Collaborator Author

vihdzp commented Jan 6, 2022

Ahh. Power names are annoying, because there are various different powers that don't really generalize. In other corners of the library, it seems like the pattern is to use the name {x}pow: rpow on the reals, zpow on groups, ... so maybe ordinal powers should be opow?

This seems like a good idea, although I'd like some more consensus before implementing it. Maybe @digama0 can weigh in?

@digama0
Copy link
Member

digama0 commented Jan 7, 2022

I'm fine with renaming it to opow.

@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 9, 2022
@vihdzp vihdzp changed the title chore(set_theory/ordinal_arithmetic): Added comment on power refactor(set_theory/ordinal_arithmetic): Rename power to opow Jan 15, 2022
@vihdzp vihdzp added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 16, 2022
@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 17, 2022
bors bot pushed a commit that referenced this pull request Jan 17, 2022
@bors
Copy link

bors bot commented Jan 17, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(set_theory/ordinal_arithmetic): Rename power to opow [Merged by Bors] - refactor(set_theory/ordinal_arithmetic): Rename power to opow Jan 17, 2022
@bors bors bot closed this Jan 17, 2022
@bors bors bot deleted the power_note branch January 17, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants