Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/well_founded_set): Antichains in a partial well order are finite #11286

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(order/well_founded_set): Antichains in a partial well order are finite #11286

wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator

and when the relation is reflexive and symmetric, it's actually an equivalent condition.

Requested by @vihdzp

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Jan 6, 2022
@YaelDillies YaelDillies mentioned this pull request Jan 6, 2022
Closed
@ocfnash ocfnash added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 7, 2022
YaelDillies
YaelDillies commented Jan 7, 2022
View reviewed changes
Copy link
Collaborator Author

@YaelDillies YaelDillies left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 7, 2022
@YaelDillies YaelDillies mentioned this pull request Jan 8, 2022
Closed
@ocfnash
Copy link
Collaborator

ocfnash commented Jan 11, 2022

I agree with the naming suggestion above

Once that's done I think this is good to merge.

bors d+

@bors
Copy link

bors bot commented Jan 11, 2022

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 11, 2022
@YaelDillies
Copy link
Collaborator Author

Yury, I will move forward with this PR given that yours is not ready yet. Sorry for the few conflicts.

bors merge

bors bot pushed a commit that referenced this pull request Jan 17, 2022
@YaelDillies
feat(order/well_founded_set): Antichains in a partial well order are …
1c56a8d 
…finite (#11286)

and when the relation is reflexive and symmetric, it's actually an equivalent condition.
@bors
Copy link

bors bot commented Jan 17, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/well_founded_set): Antichains in a partial well order are finite [Merged by Bors] - feat(order/well_founded_set): Antichains in a partial well order are finite Jan 17, 2022
@bors bors bot closed this Jan 17, 2022
@bors bors bot deleted the pwo_finite_antichain branch January 17, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

@ocfnash ocfnash ocfnash left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @ocfnash @urkud