Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(linear_algebra/finite_dimensional): Define rank of set of vectors #11290

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat(linear_algebra/finite_dimensional): Define rank of set of vectors #11290

wants to merge 11 commits into from

Conversation

cuppajoeman
Copy link
Collaborator

@cuppajoeman cuppajoeman commented Jan 6, 2022 •
edited

Added in the definition of "rank of a set of vectors" and a useful lemma about the rank when one set is a subset of the other.

Read the zulip stream here: https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/First.20Time.20Contributing

Open in Gitpod

@cuppajoeman cuppajoeman added easy < 20s of review time. See the lifecycle page for guidelines. undergrad Relates to undergrad.yaml labels Jan 6, 2022
@tb65536 tb65536 removed the easy < 20s of review time. See the lifecycle page for guidelines. label Jan 7, 2022
tb65536
tb65536 reviewed Jan 7, 2022
View reviewed changes
src/linear_algebra/finite_dimensional.lean Outdated Show resolved Hide resolved
src/linear_algebra/finite_dimensional.lean Outdated Show resolved Hide resolved
@tb65536
Copy link
Collaborator

tb65536 commented Jan 7, 2022

There are also a few more occurrences of finrank K (span K s) in the file that you could rewrite.

@tb65536 tb65536 changed the title add in rank of set of vectors def and mono lemma feat(linear_algebra/finite_dimensional): Define rank of set of vectors Jan 7, 2022
@tb65536
Copy link
Collaborator

tb65536 commented Jan 7, 2022

Looks like the proof of affine_independent.finrank_vector_span_image_finset in linear_algebra/affine_space/finite_dimensional.lean broke. Here are two options that I see:

  • You could revert the change to finrank_span_finset_eq_card.
  • You could add ←set.finrank to the rwa on line 107 of linear_algebra/affine_space/finite_dimensional.lean.

@cuppajoeman
Copy link
Collaborator Author

Looks like the proof of affine_independent.finrank_vector_span_image_finset in linear_algebra/affine_space/finite_dimensional.lean broke. Here are two options that I see:

* You could revert the change to `finrank_span_finset_eq_card`.

* You could add `←set.finrank` to the `rwa` on line 107 of `linear_algebra/affine_space/finite_dimensional.lean`.

I reverted the modifications, that decision was also echoed in zulip: https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/First.20Time.20Contributing/near/267238587

@tb65536 tb65536 added the awaiting-review The author would like community review of the PR label Jan 8, 2022
jcommelin
jcommelin approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@jcommelin
Copy link
Member

@cuppajoeman Would you mind making a follow-up PR with simp-lemmas about set.finrank of the empty set and singleton sets?

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 11, 2022
bors bot pushed a commit that referenced this pull request Jan 11, 2022
@cuppajoeman
feat(linear_algebra/finite_dimensional): Define rank of set of vectors (
be594eb 
#11290)

Added in the definition of "rank of a set of vectors" and a useful lemma about the rank when one set is a subset of the other.

Read the zulip stream here: https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/First.20Time.20Contributing



Co-authored-by: ccn <callum.cassidynolan@mail.utoronto.ca>
@bors
Copy link

bors bot commented Jan 11, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/finite_dimensional): Define rank of set of vectors [Merged by Bors] - feat(linear_algebra/finite_dimensional): Define rank of set of vectors Jan 11, 2022
@bors bors bot closed this Jan 11, 2022
@bors bors bot deleted the linalg_rank_of_vectors_cjm branch January 11, 2022 13:54
@cuppajoeman
Copy link
Collaborator Author

@cuppajoeman Would you mind making a follow-up PR with simp-lemmas about set.finrank of the empty set and singleton sets?

Hey, sorry I just checked in on this PR again, did you still need this to happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@tb65536 tb65536 tb65536 left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) undergrad Relates to undergrad.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cuppajoeman @tb65536 @jcommelin @eric-wieser @leanprover-community-bot-assistant