Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/inner_product_space/l2): Inner product space structure on l2 #11315

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat(analysis/inner_product_space/l2): Inner product space structure on l2 #11315

wants to merge 12 commits into from

Conversation

hrmacbeth
Copy link
Member

@hrmacbeth hrmacbeth commented Jan 8, 2022 •
edited by github-actions bot

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 8, 2022
@hrmacbeth hrmacbeth mentioned this pull request Jan 9, 2022
Closed
6 tasks
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 13, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

This PR/issue depends on:

@hrmacbeth hrmacbeth added the awaiting-CI The author would like to see what CI has to say before doing more work. label Jan 13, 2022
@hrmacbeth hrmacbeth added the awaiting-review The author would like community review of the PR label Jan 13, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jan 13, 2022
RemyDegenne
RemyDegenne approved these changes Jan 14, 2022
View reviewed changes
Copy link
Collaborator

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
bors d+

src/analysis/inner_product_space/l2_space.lean Outdated Show resolved Hide resolved
src/analysis/inner_product_space/l2_space.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 14, 2022

✌️ hrmacbeth can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 14, 2022
hrmacbeth and others added 2 commits January 14, 2022 02:59
@hrmacbeth @RemyDegenne
Update src/analysis/inner_product_space/l2_space.lean
135ad5d 
Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
@hrmacbeth @RemyDegenne
Update src/analysis/inner_product_space/l2_space.lean
fba5683 
Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
@hrmacbeth
Copy link
Member Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jan 14, 2022
bors bot pushed a commit that referenced this pull request Jan 14, 2022
@hrmacbeth @robertylewis
feat(analysis/inner_product_space/l2): Inner product space structure …
9a94993 
…on `l2` (#11315)




Co-authored-by: Rob Lewis <rob.y.lewis@gmail.com>
@bors
Copy link

bors bot commented Jan 14, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/inner_product_space/l2): Inner product space structure on l2 [Merged by Bors] - feat(analysis/inner_product_space/l2): Inner product space structure on l2 Jan 14, 2022
@bors bors bot closed this Jan 14, 2022
@bors bors bot deleted the l2-inner-product branch January 14, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemyDegenne RemyDegenne RemyDegenne approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hrmacbeth @leanprover-community-bot-assistant @RemyDegenne @robertylewis