Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/{multiset,finset}/sum): Disjoint sum of multisets/finsets #11355

Closed
wants to merge 7 commits into from

Conversation

YaelDillies
Copy link
Collaborator

This defines the disjoint union of two multisets/finsets as multiset (α ⊕ β)/finset (α ⊕ β).


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Jan 10, 2022
src/data/finset/sum.lean Outdated Show resolved Hide resolved
src/data/finset/sum.lean Outdated Show resolved Hide resolved
src/data/finset/sum.lean Outdated Show resolved Hide resolved
src/data/multiset/sum.lean Outdated Show resolved Hide resolved
Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/data/finset/basic.lean Outdated Show resolved Hide resolved
src/data/finset/sum.lean Outdated Show resolved Hide resolved
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 11, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 11, 2022
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 14, 2022
bors bot pushed a commit that referenced this pull request Jan 14, 2022
…11355)

This defines the disjoint union of two multisets/finsets as `multiset (α ⊕ β)`/`finset (α ⊕ β)`.
@bors
Copy link

bors bot commented Jan 14, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/{multiset,finset}/sum): Disjoint sum of multisets/finsets [Merged by Bors] - feat(data/{multiset,finset}/sum): Disjoint sum of multisets/finsets Jan 14, 2022
@bors bors bot closed this Jan 14, 2022
@bors bors bot deleted the disj_sum branch January 14, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants