[Merged by Bors] - chore(algebra/group): make coe_norm_subgroup and submodule.norm_coe consistent
#11427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vierkantor
added
the
awaiting-review
… of the `coe`s) TODO: this is probably a sign some of the other simp lemmas need to be changed, let's see if the linter can spot them
Vierkantor
force-pushed
the
reverse-submodule_norm_coe
branch
from
e2f5f0c
to
5b3705f
Compare
3 tasks
ocfnash
changed the title
coe_norm_subgroup and submodule.norm_coecoe_norm_subgroup and submodule.norm_coe consistent
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
…e` consistent (#11427) The `simp` lemmas for norms in a subgroup and in a submodule disagreed: the first inserted a coercion to the larger group, the second deleted the coercion. Currently this is not a big deal, but it will become a real issue when defining `add_subgroup_class`. I want to make them consistent by pointing them in the same direction. The consensus in the [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Simp.20normal.20form.3A.20coe_norm_subgroup.2C.20submodule.2Enorm_coe) suggests `simp` should insert a coercion here, so I went with that. After making the changes, a few places need extra `simp [submodule.coe_norm]` on the local hypotheses, but nothing major.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
coe_norm_subgroup and submodule.norm_coe consistentcoe_norm_subgroup and submodule.norm_coe consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
simplemmas for norms in a subgroup and in a submodule disagreed: the first inserted a coercion to the larger group, the second deleted the coercion. Currently this is not a big deal, but it will become a real issue when definingadd_subgroup_class. I want to make them consistent by pointing them in the same direction. The consensus in the Zulip thread suggestssimpshould insert a coercion here, so I went with that.After making the changes, a few places need extra
simp [submodule.coe_norm]on the local hypotheses, but nothing major.