Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/matrix/notation): relax typeclass assumptions #11429

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(data/matrix/notation): relax typeclass assumptions #11429

wants to merge 3 commits into from

Conversation

madvorak
Copy link
Collaborator

Open in Gitpod

@madvorak madvorak added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Jan 13, 2022
@eric-wieser eric-wieser changed the title feat(data/matrix/notation): has_mul is enough feat(data/matrix/notation): relax typeclass assumptions Jan 14, 2022
eric-wieser
eric-wieser approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Note that all of the ugly @s go away if we introduce instances like:

/-- A copy of `pi.has_add` to help lean when working with non-dependent functions. -/
instance function.has_add {α β : Type*} [has_add β] : has_add (α → β) :=
pi.has_add

If you want to explore that, feel free to make a new PR to do so.

bors d+

@bors
Copy link

bors bot commented Jan 14, 2022

✌️ madvorak can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 14, 2022
@madvorak
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 14, 2022
@madvorak
feat(data/matrix/notation): relax typeclass assumptions (#11429)
38eb719
@bors
Copy link

bors bot commented Jan 14, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/matrix/notation): relax typeclass assumptions [Merged by Bors] - feat(data/matrix/notation): relax typeclass assumptions Jan 14, 2022
@bors bors bot closed this Jan 14, 2022
@bors bors bot deleted the vec2_vec3 branch January 14, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@madvorak @eric-wieser @leanprover-community-bot-assistant