[Merged by Bors] - feat(analysis/normed_space/linear_isometry): coercion injectivity lemmas and add_monoid_hom_class #11434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
awaiting-review
This also registers `linear_isometry` and `linear_isometry_equiv` with `add_monoid_hom_class`.
eric-wieser
force-pushed
the
eric-wieser/linear_isometry-fun_like
branch
from
e5e0e18
to
774339d
Compare
eric-wieser
changed the title
eric-wieser
added
the
awaiting-CI
github-actions
bot
removed
the
awaiting-CI
jcommelin
reviewed
Jan 14, 2022
| f.to_linear_equiv = g.to_linear_equiv ↔ f = g := | ||
| to_linear_equiv_injective.eq_iff | ||
|
|
||
| instance : add_monoid_hom_class (E ≃ₛₗᵢ[σ₁₂] E₂) E E₂ := |
There was a problem hiding this comment.
Shouldn't this be an add_equiv_class instance?
There was a problem hiding this comment.
Yes, but that doesn't exist yet. This instance is better than no instance at all!
There was a problem hiding this comment.
Ooh wow, I somehow assumed that the equiv_class PR had landed two weeks ago already...
jcommelin
added
awaiting-author
eric-wieser
added
awaiting-review
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
…mas and add_monoid_hom_class (#11434) This also registers `linear_isometry` and `linear_isometry_equiv` with `add_monoid_hom_class`. I found myself wanting one of these while squeezing a simp, so may as well have all of them now.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also registers
linear_isometryandlinear_isometry_equivwithadd_monoid_hom_class.I found myself wanting one of these while squeezing a simp, so may as well have all of them now.
linear_isometry_equivended up in the wrong file in #8646, so that gets moved here.