Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(order/filter/ultrafilter): add some comap_inf_principal lemmas in the setting of ultrafilters #11445

Closed
wants to merge 1 commit into from

Conversation

berndlosert
Copy link
Collaborator

Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/contribute.20lemma.20to.20mathlib

Some background: I am developing the theory of convergence spaces in Lean. I need these lemmas in the proof that the image of a compact set under a continuous function is compact.


Open in Gitpod

Comment on lines 319 to 320
lemma eq_of_le {f g : ultrafilter α} (h : (f : filter α) ≤ g) : f = g :=
coe_injective (g.unique h)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just one direction of coe_le_coe on line 53, right? Can you change coe_le_coe to be proved in terms of this lemma?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ericrbg ericrbg added the awaiting-review The author would like community review of the PR label Jan 14, 2022
@jcommelin
Copy link
Member

Please update the PR title according to the style guide: https://github.com/leanprover-community/lean/blob/master/doc/commit_convention.md

… the setting of ultrafilters

These lemmas are useful to prove e.g. that the continuous image of a
compact set is compact in the setting of convergence spaces.
@berndlosert berndlosert changed the title Some comap_inf_principal lemmas in the setting of ultrafilters feat(order/filter/ultrafilter) add some comap_inf_principal lemmas in the setting of ultrafilters Jan 14, 2022
@berndlosert
Copy link
Collaborator Author

I updated the title and the commit.

@robertylewis robertylewis changed the title feat(order/filter/ultrafilter) add some comap_inf_principal lemmas in the setting of ultrafilters feat(order/filter/ultrafilter): add some comap_inf_principal lemmas in the setting of ultrafilters Jan 14, 2022
@PatrickMassot
Copy link
Member

@berndlosert could you please move this branch from your fork to the main repository? Out continuous integration workflow requires this in order to be able to check your code before we can make any decision. See explanations at https://leanprover-community.github.io/contribute/index.html. Also please open filter in the section you added so that we can remove all those filter..

@PatrickMassot PatrickMassot added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 16, 2022
@berndlosert
Copy link
Collaborator Author

berndlosert commented Jan 16, 2022

could you please move this branch from your fork to the main repository?

No problem. I will close this PR and open a new one.

Also please open filter in the section you added so that we can remove all those filter.

I tried doing that already, but Lean gets confused. For example, I get this error when I simply filter.comap to comap:

error: type mismatch at application
  comap m
term
  m
has type
  α → β : Type (max u v)
but is expected to have type
  ultrafilter ?m_1 : Type ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants