Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/algebra): algebra_map_int_eq #11474

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore(algebra/algebra): algebra_map_int_eq #11474

wants to merge 3 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Jan 15, 2022

from flt-regular

Open in Gitpod

@ericrbg ericrbg added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jan 15, 2022
@ericrbg
Copy link
Collaborator Author

ericrbg commented Jan 15, 2022

I wonder if the right way to do this is to create a lemma like @[simp] lemma asda : algebra.to_ring_hom = algebra_map R A := rfl and let simps do this; however, this lemma and simps {simp_rhs := tt} doesn't create the lemma we want yet

@ericrbg ericrbg removed the easy < 20s of review time. See the lifecycle page for guidelines. label Jan 15, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jan 15, 2022
@ericrbg @eric-wieser
add doc
6bf8fea 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
eric-wieser approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

I'm not convinced whether this simp-normal form is better or worse than the old one, but we can always remove simp at a later date if it becomes annoying.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 19, 2022
bors bot pushed a commit that referenced this pull request Jan 19, 2022
@ericrbg
chore(algebra/algebra): algebra_map_int_eq (#11474)
7ddaf10 
from flt-regular



Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 19, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/algebra): algebra_map_int_eq [Merged by Bors] - chore(algebra/algebra): algebra_map_int_eq Jan 19, 2022
@bors bors bot closed this Jan 19, 2022
@bors bors bot deleted the ericrbg/algebra_map_int_eq branch January 19, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericrbg @eric-wieser @leanprover-community-bot-assistant