Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/special_functions/pow): tendsto rpow lemma for ennreals #11475

Closed
wants to merge 3 commits into from

Conversation

JasonKYi
Copy link
Member


Open in Gitpod

@JasonKYi JasonKYi added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jan 15, 2022
@@ -1583,6 +1583,11 @@ begin
exact ennreal.continuous_inv.continuous_at.comp (continuous_at_rpow_const_of_pos z_pos) }
end

protected lemma tendsto.rpow {α : Type*} {f : filter α} {m : α → ℝ≥0∞} {a : ℝ≥0∞} (r : ℝ)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we already have:

  • filter.tendsto.cpow
  • filter.tendsto.rpow
  • filter.tendsto.nnrpow
  • filter.tendsto.const_cpow
  • filter.tendsto.rpow_const

Based on this I think we should:

  • Rename filter.tendsto.const_cpow to filter.tendsto.cpow_const
  • Call this lemma filter.tendsto.ennrpow_const rather than the proposed ennreal.tendsto.rpow
  • Add an appropriate lemma named filter.tendsto.ennrpow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand why we should change filter.tendsto.const_cpow to filter.tendsto.cpow_const since the lemma is about taking a constant to the power of a function

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops you're right; we definitely should not be renaming filter.tendsto.const_cpow.

However it still seems like filter.tendsto.ennrpow_const would be a more consistent name for the new lemma, even bearing in mind that it mixes types by raising an ennreal-valued function to a real.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change the name to what you suggested. I tried to prove filter.tendsto.ennrpow but it seems that we are missing a few continuity lemmas. That should probably belong in another PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it can wait!

@ocfnash ocfnash added awaiting-author A reviewer has asked the author a question or requested changes and removed easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Jan 16, 2022
@ocfnash
Copy link
Collaborator

ocfnash commented Jan 16, 2022

bors d+

@bors
Copy link

bors bot commented Jan 16, 2022

✌️ JasonKYi can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Jan 16, 2022
@JasonKYi
Copy link
Member Author

bors r+

@bors
Copy link

bors bot commented Jan 17, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/special_functions/pow): tendsto rpow lemma for ennreals [Merged by Bors] - feat(analysis/special_functions/pow): tendsto rpow lemma for ennreals Jan 17, 2022
@bors bors bot closed this Jan 17, 2022
@bors bors bot deleted the JasonKYi/ennreal_tendsto_rpow branch January 17, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants