Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(measure_theory/function/lp_space): some variations of Markov's inequality formulated using snorm #11478

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(measure_theory/function/lp_space): some variations of Markov's inequality formulated using snorm #11478

wants to merge 7 commits into from

Conversation

JasonKYi
Copy link
Member

Open in Gitpod

@JasonKYi JasonKYi added the awaiting-review The author would like community review of the PR label Jan 15, 2022
RemyDegenne
RemyDegenne reviewed Jan 17, 2022
View reviewed changes
Copy link
Collaborator

@RemyDegenne RemyDegenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add versions of these lemmas for elements of Lp? (using the norm instead of snorm).

Why did you place those lemmas at this position in the lp_space file? To me it looks disconnected from the results around.

src/measure_theory/function/lp_space.lean Outdated Show resolved Hide resolved
@JasonKYi JasonKYi added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 17, 2022
@JasonKYi
Copy link
Member Author

I put them there since that section seems to contain some inequalities about snorm. Do you have another place which you think is better?

@JasonKYi JasonKYi added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 17, 2022
sgouezel
sgouezel reviewed Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

src/measure_theory/function/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/function/lp_space.lean Outdated Show resolved Hide resolved
@JasonKYi JasonKYi added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 19, 2022
@JasonKYi JasonKYi added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 19, 2022
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 20, 2022
@JasonKYi JasonKYi added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 20, 2022
@RemyDegenne
Copy link
Collaborator

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 20, 2022
bors bot pushed a commit that referenced this pull request Jan 20, 2022
@JasonKYi
feat(measure_theory/function/lp_space): some variations of Markov's i…
adadd4a 
…nequality formulated using `snorm` (#11478)
@bors
Copy link

bors bot commented Jan 20, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/function/lp_space): some variations of Markov's inequality formulated using snorm [Merged by Bors] - feat(measure_theory/function/lp_space): some variations of Markov's inequality formulated using snorm Jan 20, 2022
@bors bors bot closed this Jan 20, 2022
@bors bors bot deleted the JasonKYi/snorm_le branch January 20, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemyDegenne RemyDegenne RemyDegenne left review comments

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JasonKYi @RemyDegenne @sgouezel