Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/pointwise): Scalar multiplication lemmas #11486

Closed
wants to merge 7 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Jan 16, 2022

This proves a bunch of lemmas about pointwise scalar multiplication of sets, moves has_vsub to algebra.group.defs and pointwise vsub lemmas to algebra.pointwise.

I'm also adding a few sections because having {s t : set α} is nice for multiplication but not for scalar multiplication.


Open in Gitpod

src/algebra/pointwise.lean Show resolved Hide resolved
src/algebra/pointwise.lean Outdated Show resolved Hide resolved
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 17, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 24, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/algebra/pointwise.lean Show resolved Hide resolved
@b-mehta
Copy link
Collaborator

b-mehta commented Jan 24, 2022

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 24, 2022
bors bot pushed a commit that referenced this pull request Jan 24, 2022
This proves a bunch of lemmas about pointwise scalar multiplication of sets, moves `has_vsub` to `algebra.group.defs` and pointwise `vsub` lemmas to `algebra.pointwise`.

I'm also adding a few sections because having `{s t : set α}` is nice for multiplication but not for scalar multiplication.
@bryangingechen
Copy link
Collaborator

Bors seems to have crashed.
bors r+

bors bot pushed a commit that referenced this pull request Jan 24, 2022
This proves a bunch of lemmas about pointwise scalar multiplication of sets, moves `has_vsub` to `algebra.group.defs` and pointwise `vsub` lemmas to `algebra.pointwise`.

I'm also adding a few sections because having `{s t : set α}` is nice for multiplication but not for scalar multiplication.
@bors
Copy link

bors bot commented Jan 24, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jan 24, 2022
This proves a bunch of lemmas about pointwise scalar multiplication of sets, moves `has_vsub` to `algebra.group.defs` and pointwise `vsub` lemmas to `algebra.pointwise`.

I'm also adding a few sections because having `{s t : set α}` is nice for multiplication but not for scalar multiplication.
@bors
Copy link

bors bot commented Jan 24, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/pointwise): Scalar multiplication lemmas [Merged by Bors] - feat(algebra/pointwise): Scalar multiplication lemmas Jan 24, 2022
@bors bors bot closed this Jan 24, 2022
@bors bors bot deleted the smul_Union branch January 24, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants