-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(algebra/lie/nilpotent): a non-trivial nilpotent Lie module has non-trivial maximal trivial submodule #11515
Conversation
…s has non-trivial maximal trivial submodule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One slight concern is that nilpotency_length
and lower_central_series_last
are both fairly long names for a definition. But maybe they will not be used too much, so it's fine.
Of course we can easily refactor later.
Co-authored-by: Johan Commelin <johan@commelin.net>
I share the concern but have persuaded myself these are OK for the reasons you state. I'm happy to rename / wait for inspiration though. Right now, I can think of the following alternatives for
and the following for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I forgot a comma,
bors d+
✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with |
Let's leave the names as is. We can refactor later. Maybe |
Co-authored-by: Johan Commelin <johan@commelin.net>
bors merge |
…on-trivial maximal trivial submodule (#11515) The main result is `lie_module.nontrivial_max_triv_of_is_nilpotent`
Pull request successfully merged into master. Build succeeded: |
The main result is
lie_module.nontrivial_max_triv_of_is_nilpotent