Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/lie/nilpotent): a non-trivial nilpotent Lie module has non-trivial maximal trivial submodule #11515

Closed
wants to merge 6 commits into from

Conversation

ocfnash
Copy link
Collaborator

@ocfnash ocfnash commented Jan 17, 2022

The main result is lie_module.nontrivial_max_triv_of_is_nilpotent


Open in Gitpod

@ocfnash ocfnash added the awaiting-review The author would like community review of the PR label Jan 17, 2022
src/algebra/lie/abelian.lean Outdated Show resolved Hide resolved
src/algebra/lie/nilpotent.lean Outdated Show resolved Hide resolved
src/algebra/lie/nilpotent.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin changed the title feat(algebra/lie/nilpotent): a non-trivial nilpotent Lie module always has non-trivial maximal trivial submodule feat(algebra/lie/nilpotent): a non-trivial nilpotent Lie module has non-trivial maximal trivial submodule Jan 17, 2022
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 17, 2022
@ocfnash ocfnash added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 17, 2022
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight concern is that nilpotency_length and lower_central_series_last are both fairly long names for a definition. But maybe they will not be used too much, so it's fine.
Of course we can easily refactor later.

src/algebra/lie/nilpotent.lean Outdated Show resolved Hide resolved
Co-authored-by: Johan Commelin <johan@commelin.net>
@ocfnash
Copy link
Collaborator Author

ocfnash commented Jan 18, 2022

One slight concern is that nilpotency_length and lower_central_series_last are both fairly long names for a definition. But maybe they will not be used too much, so it's fine. Of course we can easily refactor later.

I share the concern but have persuaded myself these are OK for the reasons you state.

I'm happy to rename / wait for inspiration though. Right now, I can think of the following alternatives for nilpotency_length:

  • nilpotency_len
  • lcs_length
  • lcs_len

and the following for lower_central_series_last just lcs_last.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I forgot a comma,

bors d+

src/algebra/lie/nilpotent.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 18, 2022

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 18, 2022
@jcommelin
Copy link
Member

Let's leave the names as is. We can refactor later. Maybe lower_central_series should just become lcs like you suggest. It has been bumping name lengths in other part of Lie theory as well. But we should then do the same in group theory.

Co-authored-by: Johan Commelin <johan@commelin.net>
@ocfnash
Copy link
Collaborator Author

ocfnash commented Jan 18, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jan 18, 2022
bors bot pushed a commit that referenced this pull request Jan 18, 2022
…on-trivial maximal trivial submodule (#11515)

The main result is `lie_module.nontrivial_max_triv_of_is_nilpotent`
@bors
Copy link

bors bot commented Jan 18, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/lie/nilpotent): a non-trivial nilpotent Lie module has non-trivial maximal trivial submodule [Merged by Bors] - feat(algebra/lie/nilpotent): a non-trivial nilpotent Lie module has non-trivial maximal trivial submodule Jan 18, 2022
@bors bors bot closed this Jan 18, 2022
@bors bors bot deleted the ocfnash/nilpotency_tail branch January 18, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants