Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra,algebra,group_theory): miscellaneous lemmas linking some additive monoid and module operations #11525

Closed
wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 17, 2022

This adds:

  • submodule.map_to_add_submonoid
  • submodule.sup_to_add_submonoid
  • submodule.supr_to_add_submonoid

As well as some missing add_submonoid lemmas copied from the submodule API:

  • add_submonoid.closure_singleton_le_iff_mem
  • add_submonoid.mem_supr
  • add_submonoid.supr_eq_closure

Finally, it generalizes some indices in supr and infi lemmas from Type* to Sort*.

This is pre-work for removing a redundant hypothesis from submodule.mul_induction_on.


Open in Gitpod

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Jan 17, 2022
…ng some additive monoid and module operations
Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this!

bors d+

src/algebra/algebra/bilinear.lean Outdated Show resolved Hide resolved
src/algebra/algebra/bilinear.lean Outdated Show resolved Hide resolved
src/group_theory/submonoid/basic.lean Outdated Show resolved Hide resolved
src/group_theory/submonoid/basic.lean Outdated Show resolved Hide resolved
src/linear_algebra/basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 18, 2022

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 18, 2022
Co-authored-by: Oliver Nash <github@olivernash.org>
@eric-wieser
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Jan 18, 2022
…ng some additive monoid and module operations (#11525)

This adds:
* `submodule.map_to_add_submonoid`
* `submodule.sup_to_add_submonoid`
* `submodule.supr_to_add_submonoid`

As well as some missing `add_submonoid` lemmas copied from the `submodule` API:
* `add_submonoid.closure_singleton_le_iff_mem`
* `add_submonoid.mem_supr`
* `add_submonoid.supr_eq_closure`

Finally, it generalizes some indices in `supr` and `infi` lemmas from `Type*` to `Sort*`.

This is pre-work for removing a redundant hypothesis from `submodule.mul_induction_on`.
@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jan 18, 2022
@bors
Copy link

bors bot commented Jan 18, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra,algebra,group_theory): miscellaneous lemmas linking some additive monoid and module operations [Merged by Bors] - feat(linear_algebra,algebra,group_theory): miscellaneous lemmas linking some additive monoid and module operations Jan 18, 2022
@bors bors bot closed this Jan 18, 2022
@bors bors bot deleted the eric-wieser/submodule-lemmas branch January 18, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants