New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(linear_algebra,algebra,group_theory): miscellaneous lemmas linking some additive monoid and module operations #11525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
awaiting-review
The author would like community review of the PR
label
Jan 17, 2022
…ng some additive monoid and module operations
eric-wieser
force-pushed
the
eric-wieser/submodule-lemmas
branch
from
January 17, 2022 18:39
0c6f636
to
dc1ff86
Compare
eric-wieser
commented
Jan 17, 2022
3 tasks
ocfnash
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all this!
bors d+
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
labels
Jan 18, 2022
eric-wieser
commented
Jan 18, 2022
Co-authored-by: Oliver Nash <github@olivernash.org>
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 18, 2022
…ng some additive monoid and module operations (#11525) This adds: * `submodule.map_to_add_submonoid` * `submodule.sup_to_add_submonoid` * `submodule.supr_to_add_submonoid` As well as some missing `add_submonoid` lemmas copied from the `submodule` API: * `add_submonoid.closure_singleton_le_iff_mem` * `add_submonoid.mem_supr` * `add_submonoid.supr_eq_closure` Finally, it generalizes some indices in `supr` and `infi` lemmas from `Type*` to `Sort*`. This is pre-work for removing a redundant hypothesis from `submodule.mul_induction_on`.
github-actions
bot
added
the
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
label
Jan 18, 2022
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(linear_algebra,algebra,group_theory): miscellaneous lemmas linking some additive monoid and module operations
[Merged by Bors] - feat(linear_algebra,algebra,group_theory): miscellaneous lemmas linking some additive monoid and module operations
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delegated
The PR author may merge after reviewing final suggestions.
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
submodule.map_to_add_submonoid
submodule.sup_to_add_submonoid
submodule.supr_to_add_submonoid
As well as some missing
add_submonoid
lemmas copied from thesubmodule
API:add_submonoid.closure_singleton_le_iff_mem
add_submonoid.mem_supr
add_submonoid.supr_eq_closure
Finally, it generalizes some indices in
supr
andinfi
lemmas fromType*
toSort*
.This is pre-work for removing a redundant hypothesis from
submodule.mul_induction_on
.