Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(measure_theory/probability_mass_function): Measures of sets under pmf monad operations #11613

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(measure_theory/probability_mass_function): Measures of sets under pmf monad operations #11613

wants to merge 5 commits into from

Conversation

dtumad
Copy link
Collaborator

@dtumad dtumad commented Jan 22, 2022 •
edited by jcommelin

This PR adds explicit formulas for the measures of sets under pmf.pure, pmf.bind, and pmf.bind_on_support.

Open in Gitpod

@dtumad dtumad added the awaiting-review The author would like community review of the PR label Jan 22, 2022
jcommelin
jcommelin reviewed Jan 26, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry that it took so long to review this. Apart from a stylistic comment, this looks good to me.

src/measure_theory/probability_mass_function/monad.lean Outdated Show resolved Hide resolved
src/measure_theory/probability_mass_function/monad.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 26, 2022
@dtumad dtumad added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 29, 2022
@RemyDegenne
Copy link
Collaborator

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 2, 2022
bors bot pushed a commit that referenced this pull request Feb 2, 2022
@dtumad
feat(measure_theory/probability_mass_function): Measures of sets unde…
c1d2860 
…r `pmf` monad operations (#11613)

This PR adds explicit formulas for the measures of sets under `pmf.pure`, `pmf.bind`, and `pmf.bind_on_support`.
@bors
Copy link

bors bot commented Feb 2, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/probability_mass_function): Measures of sets under pmf monad operations [Merged by Bors] - feat(measure_theory/probability_mass_function): Measures of sets under pmf monad operations Feb 2, 2022
@bors bors bot closed this Feb 2, 2022
@bors bors bot deleted the pmf_monad_set_measure branch February 2, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtumad @RemyDegenne @jcommelin