Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/order/hom/ring): Ordered semiring/ring homomorphisms #11634

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(algebra/order/hom/ring): Ordered semiring/ring homomorphisms #11634

wants to merge 7 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Jan 23, 2022 •
edited by github-actions bot

Define order_ring_hom with notation →+*o along with its hom class.

Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Jan 23, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 23, 2022
Vierkantor
Vierkantor reviewed Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐙

src/algebra/order/hom/ring.lean Outdated Show resolved Hide resolved
src/algebra/order/hom/ring.lean Outdated Show resolved Hide resolved
src/algebra/order/hom/ring.lean Outdated Show resolved Hide resolved
src/algebra/order/hom/ring.lean Outdated Show resolved Hide resolved
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 24, 2022
@YaelDillies
Copy link
Collaborator Author

Thanks! Once #11633 lands, I will rewrite this to incorporate order_add_monoid_hom and order_monoid_with_zero_hom.

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 26, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

This PR/issue depends on:

@YaelDillies YaelDillies mentioned this pull request Jan 31, 2022
Closed
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 31, 2022
Vierkantor
Vierkantor approved these changes Feb 10, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

bors r+

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 10, 2022
bors bot pushed a commit that referenced this pull request Feb 10, 2022
@YaelDillies
feat(algebra/order/hom/ring): Ordered semiring/ring homomorphisms (#1…
6afaf36 
…1634)

Define `order_ring_hom` with notation `→+*o` along with its hom class.
@bors
Copy link

bors bot commented Feb 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/order/hom/ring): Ordered semiring/ring homomorphisms [Merged by Bors] - feat(algebra/order/hom/ring): Ordered semiring/ring homomorphisms Feb 10, 2022
@bors bors bot closed this Feb 10, 2022
@bors bors bot deleted the order_ring_hom branch February 10, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @leanprover-community-bot-assistant @Vierkantor