[Merged by Bors] - feat(data/finset/finsupp): Finitely supported product of finsets #11639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
awaiting-review
3 tasks
alexjbest
reviewed
Jan 24, 2022
alexjbest
reviewed
Jan 24, 2022
alexjbest
reviewed
Jan 24, 2022
alexjbest
approved these changes
Jan 24, 2022
|
LGTM |
alexjbest
reviewed
Jan 24, 2022
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-bot-assistant
added
delegated
|
Thanks for the quick review! bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 24, 2022
) Define * `finsupp.indicator`: Similar to `finsupp.on_finset` except that it only requires a partially defined function. This is more compatible with `finset.pi`. * `finset.finsupp : finset ι → (ι → finset α) → finset (ι →₀ α)`: Finitely supported product of finsets. * `finsupp.pi : (ι →₀ finset α) → finset (ι →₀ α)`: The set of finitely supported functions whose `i`-th value lies in the `i`-th of a given `finset`-valued `finsupp`.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jan 24, 2022
) Define * `finsupp.indicator`: Similar to `finsupp.on_finset` except that it only requires a partially defined function. This is more compatible with `finset.pi`. * `finset.finsupp : finset ι → (ι → finset α) → finset (ι →₀ α)`: Finitely supported product of finsets. * `finsupp.pi : (ι →₀ finset α) → finset (ι →₀ α)`: The set of finitely supported functions whose `i`-th value lies in the `i`-th of a given `finset`-valued `finsupp`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define
finsupp.indicator: Similar tofinsupp.on_finsetexcept that it only requires a partially defined function. This is more compatible withfinset.pi.finset.finsupp : finset ι → (ι → finset α) → finset (ι →₀ α): Finitely supported product of finsets.finsupp.pi : (ι →₀ finset α) → finset (ι →₀ α): The set of finitely supported functions whosei-th value lies in thei-th of a givenfinset-valuedfinsupp.This is categorically pleasing.