Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/filter/countable_Inter): review #11673

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(order/filter/countable_Inter): review #11673

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 26, 2022

  • drop _sets in more names;
  • add filter.of_countable_Inter and instances for
    filter.map/filter.comap;
  • add docs.

Open in Gitpod

@urkud
feat(order/filter/countable_Inter): review
a763de5 
- drop `_sets` in more names;
- add `filter.of_countable_Inter` and instances for
  `filter.map`/`filter.comap`;
- add docs.
@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI The author would like to see what CI has to say before doing more work. labels Jan 26, 2022
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jan 26, 2022
jcommelin
jcommelin approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 28, 2022
bors bot pushed a commit that referenced this pull request Jan 28, 2022
@urkud
feat(order/filter/countable_Inter): review (#11673)
1e44add 
- drop `_sets` in more names;
- add `filter.of_countable_Inter` and instances for
  `filter.map`/`filter.comap`;
- add docs.
@bors
Copy link

bors bot commented Jan 28, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/filter/countable_Inter): review [Merged by Bors] - feat(order/filter/countable_Inter): review Jan 28, 2022
@bors bors bot closed this Jan 28, 2022
@bors bors bot deleted the YK-countable-Inter branch January 28, 2022 15:18
ericrbg pushed a commit that referenced this pull request Jan 28, 2022
@urkud @ericrbg
feat(order/filter/countable_Inter): review (#11673)
527c794 
- drop `_sets` in more names;
- add `filter.of_countable_Inter` and instances for
  `filter.map`/`filter.comap`;
- add docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @leanprover-community-bot-assistant