Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/list/*): subperm_singleton_iff #11680

Closed
wants to merge 4 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Jan 27, 2022


Open in Gitpod

@ericrbg ericrbg added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Jan 27, 2022
Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@@ -131,6 +131,9 @@ lemma le_count_iff_repeat_sublist {a : α} {l : list α} {n : ℕ} :
by rw ← this; apply filter_sublist,
λ h, by simpa only [count_repeat] using h.count_le a⟩

@[simp] lemma one_le_count_iff_mem {a : α} {l : list α} : 1 ≤ count a l ↔ a ∈ l :=
by { convert list.le_count_iff_repeat_sublist, simp }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an easier proof of this via count_pos?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, yes, I knew it had to be there already. i also made count_pos a simp-lemma - I'm fairly unsure whether we should do that for both, or not.

@bors
Copy link

bors bot commented Jan 27, 2022

✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 27, 2022
@ericrbg
Copy link
Collaborator Author

ericrbg commented Jan 28, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jan 28, 2022
@bors
Copy link

bors bot commented Jan 28, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/list/*): subperm_singleton_iff [Merged by Bors] - feat(data/list/*): subperm_singleton_iff Jan 28, 2022
@bors bors bot closed this Jan 28, 2022
@bors bors bot deleted the ericrbg/subperm_singleton_iff branch January 28, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants