Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(set_theory/principal): prove theorems about additive principal ordinals #11704

Closed
wants to merge 55 commits into from

Conversation

vihdzp
Copy link
Collaborator

@vihdzp vihdzp commented Jan 27, 2022


Split off from #11701. I'm really sorry, I truly don't mean to spam PRs. If all goes well I'll repurpose that PR for multiplicative principals.

Splitting off only the theorems on additive principal ordinals leaves ordinal_arithmetic in a really awkward state, where it doesn't contain theorems on additive principals yet contains various theorems on multiplicative and exponential principals, stated differently. Fortunately these theorems aren't really used much in mathlib, so this temporary awkwardness isn't too much of a problem.

Splitting off the multiplicative principal results and adding everything else of relevance would make the PR huge. Trust me, I've tried.

Open in Gitpod

@vihdzp vihdzp added the awaiting-review The author would like community review of the PR label Jan 27, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 27, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Feb 3, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Feb 4, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Feb 5, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Feb 14, 2022
Copy link
Member

@robertylewis robertylewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very clean to me, I have no substantial comments!

src/set_theory/ordinal_arithmetic.lean Show resolved Hide resolved
@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 18, 2022
@vihdzp vihdzp added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 22, 2022
@Vierkantor Vierkantor changed the title feat(set_theory/principal): Proved theorems about additive principal ordinals feat(set_theory/principal): prove theorems about additive principal ordinals Feb 28, 2022
Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

src/set_theory/principal.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Mar 2, 2022

✌️ vihdzp can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 2, 2022
@vihdzp
Copy link
Collaborator Author

vihdzp commented Mar 2, 2022

bors r+

bors bot pushed a commit that referenced this pull request Mar 2, 2022
@bors
Copy link

bors bot commented Mar 2, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(set_theory/principal): prove theorems about additive principal ordinals [Merged by Bors] - feat(set_theory/principal): prove theorems about additive principal ordinals Mar 2, 2022
@bors bors bot closed this Mar 2, 2022
@bors bors bot deleted the principal_add_real branch March 2, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants