Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/localization): fraction rings of algebraic extensions are algebraic #11717

Closed
wants to merge 21 commits into from
Closed

[Merged by Bors] - feat(ring_theory/localization): fraction rings of algebraic extensions are algebraic #11717

wants to merge 21 commits into from

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Jan 29, 2022 •
edited by github-actions bot

chughes and others added 19 commits January 28, 2022 13:03
feat(data/polynomial/reverse): lemmas about evaluating reversed polyn…
b656bdb 
…omial
use invertible to state lemmas
ca89e4d
more lemmas
b12c726
swap direction
a3efe06
start work
ee54769
@ChrisHughes24
chore(ring_theory/ocalization) weaken hypothesis from field to comm_ring
1a3c767 
also making `B` an explicit argument
almost finish proof
8d38cb5
Merge remote-tracking branch 'origin/master' into fraction_ring_algeb…
ee57e20 
…raic
fix build
c5a41da
fix build
9b0ab7b
almost finish proof
8a22777
fix build
a66869c
Merge remote-tracking branch 'origin/ChrisHughes24-patch-2' into frac…
98433f3 
…tion_ring_algebraic
Merge remote-tracking branch 'origin/master' into fraction_ring_algeb…
dfaa923 
…raic
lint fix
87b63a1
finish proof
0cbd387
Merge remote-tracking branch 'origin/ChrisHughes24-patch-2' into frac…
7a6f065 
…tion_ring_algebraic
fix build
55309ac
Merge remote-tracking branch 'origin/ChrisHughes24-patch-2' into frac…
b4e1285 
…tion_ring_algebraic
@ChrisHughes24 ChrisHughes24 added the awaiting-review The author would like community review of the PR label Jan 29, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 29, 2022
@ChrisHughes24 ChrisHughes24 mentioned this pull request Jan 29, 2022
Closed
3 tasks
@ChrisHughes24 ChrisHughes24 mentioned this pull request Jan 29, 2022
Closed
13 tasks
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 31, 2022
@leanprover-community-bot-assistant
Copy link
Collaborator

This PR/issue depends on:

jcommelin
jcommelin approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 1, 2022
bors bot pushed a commit that referenced this pull request Feb 1, 2022
@ChrisHughes24
feat(ring_theory/localization): fraction rings of algebraic extension…
5582d84 
…s are algebraic (#11717)




Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 1, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/localization): fraction rings of algebraic extensions are algebraic [Merged by Bors] - feat(ring_theory/localization): fraction rings of algebraic extensions are algebraic Feb 1, 2022
@bors bors bot closed this Feb 1, 2022
@bors bors bot deleted the fraction_ring_algebraic branch February 1, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChrisHughes24 @leanprover-community-bot-assistant @jcommelin