Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/filter/bases): basis of infimum of filters #11855

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(order/filter/bases): basis of infimum of filters #11855

wants to merge 2 commits into from

Conversation

ADedecker
Copy link
Member

Open in Gitpod

@ADedecker ADedecker added the awaiting-review The author would like community review of the PR label Feb 5, 2022
@urkud
Copy link
Member

urkud commented Feb 10, 2022 •
edited

Could you please apply this lemma to prove some reasonable has_basis for filter.pi? Or you prefer to merge this PR first?

@ADedecker
Copy link
Member Author

Sure, I'll do that in a few hours.

@TwoFX TwoFX added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 10, 2022
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 11, 2022
@urkud
Copy link
Member

urkud commented Feb 14, 2022

Thanks!
bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 14, 2022
bors bot pushed a commit that referenced this pull request Feb 14, 2022
@ADedecker
feat(order/filter/bases): basis of infimum of filters (#11855)
77dfac2
@bors
Copy link

bors bot commented Feb 14, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/filter/bases): basis of infimum of filters [Merged by Bors] - feat(order/filter/bases): basis of infimum of filters Feb 14, 2022
@bors bors bot closed this Feb 14, 2022
@bors bors bot deleted the AD_has_basis_infi branch February 14, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ADedecker @urkud @TwoFX