Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/finsupp/basic): generalize comap_mul_action #11900

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Feb 7, 2022

This new definition is propoitionally equal to the old one in the presence of [group G] (all the previous lemmas continue to apply), but generalizes to [monoid G].

This also removes finsupp.comap_distrib_mul_action_self as there is no need to have this as a separate definition.


Open in Gitpod

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Feb 7, 2022
@jcommelin
Copy link
Member

Hmm, maybe let's wait for CI first. Sorry for the slightly-to-fast bors merge

bors r-

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@jcommelin jcommelin added the awaiting-CI The author would like to see what CI has to say before doing more work. label Feb 7, 2022
@bors
Copy link

bors bot commented Feb 7, 2022

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bors
Copy link

bors bot commented Feb 7, 2022

Canceled.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-CI The author would like to see what CI has to say before doing more work. labels Feb 7, 2022
@eric-wieser
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Feb 7, 2022
This new definition is propoitionally equal to the old one in the presence of `[group G]` (all the previous `lemma`s continue to apply), but generalizes to `[monoid G]`.

This also removes `finsupp.comap_distrib_mul_action_self` as there is no need to have this as a separate definition.
@bors
Copy link

bors bot commented Feb 7, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/finsupp/basic): generalize comap_mul_action [Merged by Bors] - chore(data/finsupp/basic): generalize comap_mul_action Feb 7, 2022
@bors bors bot closed this Feb 7, 2022
@bors bors bot deleted the eric-wieser/comap_mul_action branch February 7, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants