Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(model_theory/substructures): More operations on substructures #11906

Closed
wants to merge 2 commits into from

Conversation

awainverse
Copy link
Collaborator

Defines the substructure first_order.language.hom.range.
Defines the homomorphisms first_order.language.hom.dom_restrict and first_order.language.hom.cod_restrict, and the embeddings first_order.language.embedding.dom_restrict, first_order.language.embedding.cod_restrict which restrict the domain or codomain of a first-order hom or embedding to a substructure.
Defines the embedding first_order.language.substructure.inclusion between nested substructures.


Open in Gitpod

Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments

bors d+

src/model_theory/substructures.lean Outdated Show resolved Hide resolved
src/model_theory/substructures.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 8, 2022

✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 8, 2022
@awainverse
Copy link
Collaborator Author

bors d+

@bors
Copy link

bors bot commented Feb 8, 2022

✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@awainverse
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Feb 8, 2022
…11906)

Defines the substructure `first_order.language.hom.range`.
Defines the homomorphisms `first_order.language.hom.dom_restrict` and `first_order.language.hom.cod_restrict`, and the embeddings `first_order.language.embedding.dom_restrict`, `first_order.language.embedding.cod_restrict` which restrict the domain or codomain of a first-order hom or embedding to a substructure.
Defines the embedding `first_order.language.substructure.inclusion` between nested substructures.
@bors
Copy link

bors bot commented Feb 8, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(model_theory/substructures): More operations on substructures [Merged by Bors] - feat(model_theory/substructures): More operations on substructures Feb 8, 2022
@bors bors bot closed this Feb 8, 2022
@bors bors bot deleted the substructure_ops branch February 8, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants