-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(analysis/inner_product_space/pi_L2): map_isometry_euclidean_of_orthonormal
#11907
Conversation
…orthonormal` Add a lemma giving the result of `isometry_euclidean_of_orthonormal` when applied to an orthonormal basis obtained from another orthonormal basis with `basis.map`.
@@ -176,6 +177,12 @@ rfl | |||
((v.isometry_euclidean_of_orthonormal hv).symm : euclidean_space 𝕜 ι → E) = v.equiv_fun.symm := | |||
rfl | |||
|
|||
@[simp] lemma basis.map_isometry_euclidean_of_orthonormal (v : basis ι 𝕜 E) (hv : orthonormal 𝕜 v) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually useful as a simp
lemma? Wouldn't you just want to call it explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I think the RHS is simpler than the LHS, and I've used it as a simp
lemma (to prove the corresponding simp
lemma for the composition of complex.isometry_euclidean
and isometry_euclidean_of_orthonormal
, which in turn is used in defining and proving properties of oriented angles). If these aren't simp
lemmas they can of course be named directly in the relevant simp
calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this should be simp
lemma. It may not fire very often but the fact that f
appears only once on the RHS convinces me it is the simpler form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
bors d+
✌️ jsm28 can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Oliver Nash <github@olivernash.org>
bors r+ |
…orthonormal` (#11907) Add a lemma giving the result of `isometry_euclidean_of_orthonormal` when applied to an orthonormal basis obtained from another orthonormal basis with `basis.map`.
This PR was included in a batch that was canceled, it will be automatically retried |
…orthonormal` (#11907) Add a lemma giving the result of `isometry_euclidean_of_orthonormal` when applied to an orthonormal basis obtained from another orthonormal basis with `basis.map`.
Pull request successfully merged into master. Build succeeded: |
map_isometry_euclidean_of_orthonormal
map_isometry_euclidean_of_orthonormal
Add a lemma giving the result of
isometry_euclidean_of_orthonormal
when applied to an orthonormal basis obtained from another orthonormal
basis with
basis.map
.