Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/inner_product_space/pi_L2): map_isometry_euclidean_of_orthonormal #11907

Closed
wants to merge 3 commits into from

Conversation

jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Feb 8, 2022

Add a lemma giving the result of isometry_euclidean_of_orthonormal
when applied to an orthonormal basis obtained from another orthonormal
basis with basis.map.


Open in Gitpod

…orthonormal`

Add a lemma giving the result of `isometry_euclidean_of_orthonormal`
when applied to an orthonormal basis obtained from another orthonormal
basis with `basis.map`.
@jsm28 jsm28 added the awaiting-review The author would like community review of the PR label Feb 8, 2022
@@ -176,6 +177,12 @@ rfl
((v.isometry_euclidean_of_orthonormal hv).symm : euclidean_space 𝕜 ι → E) = v.equiv_fun.symm :=
rfl

@[simp] lemma basis.map_isometry_euclidean_of_orthonormal (v : basis ι 𝕜 E) (hv : orthonormal 𝕜 v)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually useful as a simp lemma? Wouldn't you just want to call it explicitly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think the RHS is simpler than the LHS, and I've used it as a simp lemma (to prove the corresponding simp lemma for the composition of complex.isometry_euclidean and isometry_euclidean_of_orthonormal, which in turn is used in defining and proving properties of oriented angles). If these aren't simp lemmas they can of course be named directly in the relevant simp calls.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this should be simp lemma. It may not fire very often but the fact that f appears only once on the RHS convinces me it is the simpler form.

Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

bors d+

src/analysis/inner_product_space/pi_L2.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 10, 2022

✌️ jsm28 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 10, 2022
@jsm28
Copy link
Collaborator Author

jsm28 commented Feb 10, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 10, 2022
…orthonormal` (#11907)

Add a lemma giving the result of `isometry_euclidean_of_orthonormal`
when applied to an orthonormal basis obtained from another orthonormal
basis with `basis.map`.
@bors
Copy link

bors bot commented Feb 10, 2022

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request Feb 10, 2022
…orthonormal` (#11907)

Add a lemma giving the result of `isometry_euclidean_of_orthonormal`
when applied to an orthonormal basis obtained from another orthonormal
basis with `basis.map`.
@bors
Copy link

bors bot commented Feb 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/inner_product_space/pi_L2): map_isometry_euclidean_of_orthonormal [Merged by Bors] - feat(analysis/inner_product_space/pi_L2): map_isometry_euclidean_of_orthonormal Feb 10, 2022
@bors bors bot closed this Feb 10, 2022
@bors bors bot deleted the jsm28/map_isometry_euclidean branch February 10, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants