Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/lie/engel): add proof of Engel's theorem #11922

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(algebra/lie/engel): add proof of Engel's theorem #11922

wants to merge 4 commits into from

Conversation

ocfnash
Copy link
Collaborator

@ocfnash ocfnash commented Feb 8, 2022

Open in Gitpod

@ocfnash ocfnash added the awaiting-review The author would like community review of the PR label Feb 8, 2022
jcommelin
jcommelin reviewed Feb 8, 2022
View reviewed changes
src/algebra/lie/engel.lean Outdated Show resolved Hide resolved
src/algebra/lie/engel.lean Outdated Show resolved Hide resolved
src/algebra/lie/engel.lean Outdated Show resolved Hide resolved
src/algebra/lie/engel.lean Outdated Show resolved Hide resolved
src/algebra/lie/engel.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 8, 2022
kbuzzard
kbuzzard reviewed Feb 8, 2022
View reviewed changes
src/algebra/lie/engel.lean Outdated Show resolved Hide resolved
@ocfnash @kbuzzard
Update src/algebra/lie/engel.lean
b540114 
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
@ocfnash ocfnash added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 8, 2022
jcommelin
jcommelin reviewed Feb 9, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some docstring remarks

src/algebra/lie/engel.lean Show resolved Hide resolved
src/algebra/lie/engel.lean Show resolved Hide resolved
src/algebra/lie/engel.lean Show resolved Hide resolved
jcommelin
jcommelin approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 10, 2022
bors bot pushed a commit that referenced this pull request Feb 10, 2022
@ocfnash
feat(algebra/lie/engel): add proof of Engel's theorem (#11922)
0490977
@bors
Copy link

bors bot commented Feb 10, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/lie/engel): add proof of Engel's theorem [Merged by Bors] - feat(algebra/lie/engel): add proof of Engel's theorem Feb 10, 2022
@bors bors bot closed this Feb 10, 2022
@bors bors bot deleted the ocfnash/lie_nilpotency branch February 10, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@kbuzzard kbuzzard kbuzzard left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ocfnash @eric-wieser @jcommelin @kbuzzard @leanprover-community-bot-assistant