[Merged by Bors] - chore(field_theory/galois): make intermediate_field.fixing_subgroup_equiv computable
#11938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
awaiting-review
leanprover-community-bot-assistant
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
…equiv` computable (#11938) This also golfs and generalizes some results to reuse infrastructure from elsewhere. In particular, this generalizes: * `intermediate_field.fixed_field` to `fixed_points.intermediate_field`, where the latter matches the API of `fixed_points.subfield` * `intermediate_field.fixing_subgroup` to `fixing_subgroup` and `fixing_submonoid` This removes `open_locale classical` in favor of ensuring the lemmas take in the necessary decidable / fintype arguments.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
…equiv` computable (#11938) This also golfs and generalizes some results to reuse infrastructure from elsewhere. In particular, this generalizes: * `intermediate_field.fixed_field` to `fixed_points.intermediate_field`, where the latter matches the API of `fixed_points.subfield` * `intermediate_field.fixing_subgroup` to `fixing_subgroup` and `fixing_submonoid` This removes `open_locale classical` in favor of ensuring the lemmas take in the necessary decidable / fintype arguments.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
intermediate_field.fixing_subgroup_equiv computableintermediate_field.fixing_subgroup_equiv computable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also golfs and generalizes some results to reuse infrastructure from elsewhere.
In particular, this generalizes:
intermediate_field.fixed_fieldtofixed_points.intermediate_field, where the latter matches the API offixed_points.subfieldintermediate_field.fixing_subgrouptofixing_subgroupandfixing_submonoidThis removes
open_locale classicalin favor of ensuring the lemmas take in the necessary decidable / fintype arguments.