Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(group_theory/subgroup/basic): Centralizer subgroup #11946

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat(group_theory/subgroup/basic): Centralizer subgroup #11946

wants to merge 11 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Feb 10, 2022 •
edited by eric-wieser

This PR defines the centralizer subgroup, and provides a few basic lemmas.

Open in Gitpod

Zulip

@tb65536 tb65536 added the awaiting-review The author would like community review of the PR label Feb 10, 2022
Vierkantor
Vierkantor approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the set.centralizer question. I'll ask on Zulip whether that should block this PR.

@eric-wieser eric-wieser mentioned this pull request Feb 27, 2022
Closed
semorrison
semorrison approved these changes Feb 27, 2022
View reviewed changes
Copy link
Collaborator

@semorrison semorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bors
Copy link

bors bot commented Feb 27, 2022

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

eric-wieser
eric-wieser approved these changes Feb 27, 2022
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@leanprover-community-bot-assistant leanprover-community-bot-assistant added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Feb 27, 2022
tb65536 and others added 2 commits February 27, 2022 15:24
@tb65536 @eric-wieser
Update src/group_theory/submonoid/centralizer.lean
2159f42 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@tb65536 @eric-wieser
Update src/group_theory/submonoid/centralizer.lean
35712ea 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@tb65536
Copy link
Collaborator Author

tb65536 commented Feb 28, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 28, 2022
@tb65536
feat(group_theory/subgroup/basic): Centralizer subgroup (#11946)
f3a04ed 
This PR defines the centralizer subgroup, and provides a few basic lemmas.



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 28, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/subgroup/basic): Centralizer subgroup [Merged by Bors] - feat(group_theory/subgroup/basic): Centralizer subgroup Feb 28, 2022
@bors bors bot closed this Feb 28, 2022
@bors bors bot deleted the subgroup_centralizer branch February 28, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@semorrison semorrison semorrison approved these changes

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tb65536 @eric-wieser @semorrison @Vierkantor @leanprover-community-bot-assistant